From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Philippe Blain <levraiphilippeblain@gmail.com>,
Linus Arver <linusa@google.com>,
Git mailing list <git@vger.kernel.org>
Subject: Re: [PATCH] trailer: fix comment/cut-line regression with opts->no_divider
Date: Mon, 19 Feb 2024 19:26:43 -0800 [thread overview]
Message-ID: <xmqqttm3x1cc.fsf@gitster.g> (raw)
In-Reply-To: <20240220010936.GA1793660@coredump.intra.peff.net> (Jeff King's message of "Mon, 19 Feb 2024 20:09:36 -0500")
Jeff King <peff@peff.net> writes:
> On Mon, Feb 19, 2024 at 10:42:45AM -0800, Junio C Hamano wrote:
>
>> Thanks, both, for finding a rather unfortunate regression. Perhaps
>> it is worth delaying 2.44 final by a week or so to include a fix (or
>> a revert if it comes to it).
>
> Hmm, I had thought this was pre-2.44, but it was actually in the 2.43.x
> maintenance series (so it is not a regression going from 2.43.2 to
> 2.44.0, but it is from 2.43.0 to 2.44.0).
I've been trying to be a bit aggressive this cycle to merge various
clean-up topics, together with real bugfixes, to 'maint'. Those who
often skip the -rcX but diligently follow numbered releases found a
few potential regressions in 2.44-rc as a result, which I could say
is a great success ;-). In addition, I was planning to have only
one -rc release without going -rc2 before the final, but we may need
one if only for this fix.
The fix in the patch looks quite straight-forward. Thanks.
next prev parent reply other threads:[~2024-02-20 3:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 21:04 [BUG] git commit --trailer --verbose puts trailer below scissors line Philippe Blain
2024-02-16 21:19 ` Junio C Hamano
2024-02-16 22:34 ` Linus Arver
2024-02-17 6:04 ` Jeff King
2024-02-19 17:41 ` Philippe Blain
2024-02-19 18:42 ` Junio C Hamano
2024-02-20 1:09 ` [PATCH] trailer: fix comment/cut-line regression with opts->no_divider Jeff King
2024-02-20 3:26 ` Junio C Hamano [this message]
2024-03-08 2:21 ` Linus Arver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqttm3x1cc.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=levraiphilippeblain@gmail.com \
--cc=linusa@google.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).