From: Junio C Hamano <gitster@pobox.com>
To: Kousik Sanagavarapu <five231003@gmail.com>
Cc: git@vger.kernel.org,
Christian Couder <christian.couder@gmail.com>,
Hariom Verma <hariom18599@gmail.com>
Subject: Re: [PATCH 1/2] t/t6300: introduce test_bad_atom()
Date: Wed, 20 Sep 2023 16:09:21 -0700 [thread overview]
Message-ID: <xmqqttro787y.fsf@gitster.g> (raw)
In-Reply-To: <xmqqy1h078tf.fsf@gitster.g> (Junio C. Hamano's message of "Wed, 20 Sep 2023 15:56:28 -0700")
Junio C Hamano <gitster@pobox.com> writes:
>> + case "$1" in
>> + head) ref=refs/heads/main ;;
>> + tag) ref=refs/tags/testtag ;;
>> + sym) ref=refs/heads/sym ;;
>> + *) ref=$1 ;;
>> + esac
>
> Somehow this indirection makes the two examples we see below harder
> to understand. ... It does not help that both 'head' and
> 'sym' refer to a local branch ...
Ah, this "sym" thing is a (rather unnatural) symbolic ref inside
refs/heads/ hierarchy, so the naming makes halfway sense. As it is
also used in test_atom, I no longer find it all that much disturbing.
Everything else I said in my review still stands, I would think.
Thanks.
next prev parent reply other threads:[~2023-09-20 23:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 19:05 [PATCH 0/2] Add mailmap support to ref-filter Kousik Sanagavarapu
2023-09-20 19:05 ` [PATCH 1/2] t/t6300: introduce test_bad_atom() Kousik Sanagavarapu
2023-09-20 22:56 ` Junio C Hamano
2023-09-20 23:09 ` Junio C Hamano [this message]
2023-09-20 23:21 ` Junio C Hamano
2023-09-21 18:57 ` Kousik Sanagavarapu
2023-09-20 19:05 ` [PATCH 2/2] ref-filter: add mailmap support Kousik Sanagavarapu
2023-09-25 17:43 ` [PATCH v2 0/3] Add mailmap support to ref-filter Kousik Sanagavarapu
2023-09-25 17:43 ` [PATCH v2 1/3] t/t6300: cleanup test_atom Kousik Sanagavarapu
2023-09-25 17:43 ` [PATCH v2 2/3] t/t6300: introduce test_bad_atom Kousik Sanagavarapu
2023-09-25 17:43 ` [PATCH v2 3/3] ref-filter: add mailmap support Kousik Sanagavarapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqttro787y.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=christian.couder@gmail.com \
--cc=five231003@gmail.com \
--cc=git@vger.kernel.org \
--cc=hariom18599@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).