git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Kousik Sanagavarapu <five231003@gmail.com>
Cc: Christian Hesse <list@eworm.de>,
	Git Mailing List <git@vger.kernel.org>,
	Christian Couder <christian.couder@gmail.com>,
	Hariom Verma <hariom18599@gmail.com>,
	Eric Sunshine <sunshine@sunshineco.com>,
	Christian Hesse <mail@eworm.de>
Subject: Re: [PATCH v2 2/2] t/t6300: drop magic filtering
Date: Wed, 23 Aug 2023 09:14:34 -0700	[thread overview]
Message-ID: <xmqqttspg2hh.fsf@gitster.g> (raw)
In-Reply-To: <ZOYHjwOFdFGjFm1W@five231003> (Kousik Sanagavarapu's message of "Wed, 23 Aug 2023 18:50:15 +0530")

Kousik Sanagavarapu <five231003@gmail.com> writes:

> On Wed, Aug 23, 2023 at 08:52:17AM +0200, Christian Hesse wrote:
>> From: Christian Hesse <mail@eworm.de>
>> 
>> Now that we ran a trustdb check forcibly it does no longer pollute the
>> output. Filtering is no longer required...
>
> s/forcibly/forcibly, 
>
> s/it does no longer pollute/it no longer pollutes

Thanks.  I've updated the patch locally to read like so:

----- >8 -----
From: Christian Hesse <mail@eworm.de>
Date: Tue, 22 Aug 2023 15:03:15 +0200
Subject: [PATCH] t/t6300: drop magic filtering

Now that we ran a trustdb check forcibly, it no longer pollutes the
output, and filtering is no longer required.

Signed-off-by: Christian Hesse <mail@eworm.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 t/t6300-for-each-ref.sh | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/t/t6300-for-each-ref.sh b/t/t6300-for-each-ref.sh
index 5b434ab451..aa3c7c03c4 100755
--- a/t/t6300-for-each-ref.sh
+++ b/t/t6300-for-each-ref.sh
@@ -1763,10 +1763,7 @@ test_expect_success GPGSSH 'setup for signature atom using ssh' '
 '
 
 test_expect_success GPG2 'bare signature atom' '
-	git verify-commit first-signed 2>out.raw &&
-	grep -Ev "checking the trustdb|PGP trust model" out.raw >out &&
-	head -3 out >expect &&
-	tail -1 out >>expect &&
+	git verify-commit first-signed 2>expect &&
 	echo  >>expect &&
 	git for-each-ref refs/tags/first-signed \
 		--format="%(signature)" >actual &&
-- 
2.42.0


  reply	other threads:[~2023-08-23 16:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-21 20:06 [PATCH 1/1] t6300: fix match with insecure memory Christian Hesse
2023-08-21 20:24 ` Christian Hesse
2023-08-21 20:25   ` [PATCH v2 " Christian Hesse
2023-08-22  7:54     ` Kousik Sanagavarapu
2023-08-22  9:04       ` Christian Hesse
2023-08-22 13:01         ` Christian Hesse
2023-08-22 13:03           ` [PATCH 1/2] t/lib-gpg: forcibly run a trustdb update Christian Hesse
2023-08-22 13:03             ` [PATCH 2/2] t/t6300: drop magic filtering Christian Hesse
2023-08-22 16:43               ` Eric Sunshine
2023-08-23  6:52                 ` [PATCH v2 " Christian Hesse
2023-08-23 13:20                   ` Kousik Sanagavarapu
2023-08-23 16:14                     ` Junio C Hamano [this message]
2023-08-23 16:02                 ` [PATCH " Junio C Hamano
2023-08-22 15:50         ` [PATCH v2 1/1] t6300: fix match with insecure memory Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqttspg2hh.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=christian.couder@gmail.com \
    --cc=five231003@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=hariom18599@gmail.com \
    --cc=list@eworm.de \
    --cc=mail@eworm.de \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).