git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Oscar Dominguez via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Oscar Dominguez <dominguez.celada@gmail.com>
Subject: Re: [PATCH 1/2] ci(main): upgrade actions/checkout to v3
Date: Mon, 10 Oct 2022 13:55:51 -0700	[thread overview]
Message-ID: <xmqqtu4b1jqg.fsf@gitster.g> (raw)
In-Reply-To: <2dbb779f7fde175a8acd8e9de7c81db32fdf3e81.1665388136.git.gitgitgadget@gmail.com> (Oscar Dominguez via GitGitGadget's message of "Mon, 10 Oct 2022 07:48:55 +0000")

"Oscar Dominguez via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Oscar Dominguez <dominguez.celada@gmail.com>
>
> to be up to date with actions/checkout opens the door to use the latest
> features if necessary and get the latest security patches.
>
> Signed-off-by: Oscar Dominguez Celada <dominguez.celada@gmail.com>
> ---
>  .github/workflows/main.yml | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)

Hmph.  When 0dc787a9 (ci: accelerate the checkout, 2021-07-04)
updated us from actions/checkout@v1 to actions/checkout@v2 it listed
a lot more concrete "what we gain by doing this change", than the
hand-wavy "opens the door" argument.

And it left container jobs at @v1 with an explanation that @v2
seemed to be incompatible.  If the issue has that been resolved in
@v3, it would be necessary to say that the issue has been resolved
and it is safe to use @v3 there in the proposed log message.

> diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
> index 831f4df56c5..8dc9d938159 100644
> --- a/.github/workflows/main.yml
> +++ b/.github/workflows/main.yml
> ...
> @@ -291,7 +291,7 @@ jobs:
>      runs-on: ubuntu-latest
>      container: ${{matrix.vector.image}}
>      steps:
> -    - uses: actions/checkout@v1
> +    - uses: actions/checkout@v3
>      - run: ci/install-docker-dependencies.sh
>      - run: ci/run-build-and-tests.sh
>      - name: print test failures

  reply	other threads:[~2022-10-10 20:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-10  7:48 [PATCH 0/2] ci(main): upgrade actions/checkout to v3 Oscar Dominguez via GitGitGadget
2022-10-10  7:48 ` [PATCH 1/2] " Oscar Dominguez via GitGitGadget
2022-10-10 20:55   ` Junio C Hamano [this message]
2022-10-10  7:48 ` [PATCH 2/2] ci(main): linux32 uses actions/checkout@v2 Oscar Dominguez via GitGitGadget
2022-10-10 21:00   ` Junio C Hamano
2022-10-10 21:43   ` Junio C Hamano
2022-12-05 10:01 ` [PATCH v2] ci(main): upgrade actions/checkout to v3 Oscar Dominguez via GitGitGadget
2022-12-05 23:28   ` Junio C Hamano
2022-12-06  8:24   ` [PATCH] ci: use actions/{upload,download}-artifact@v3 Junio C Hamano
2022-12-06 21:21     ` Johannes Schindelin
2022-12-06 23:41       ` Junio C Hamano
2022-12-07  0:35         ` Junio C Hamano
2022-12-07 12:33           ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqtu4b1jqg.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=dominguez.celada@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).