* [PATCH] completion: tcsh: Fix regression by drop of wrapper functions
@ 2021-08-18 13:27 Takashi Iwai
2021-08-18 20:57 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Takashi Iwai @ 2021-08-18 13:27 UTC (permalink / raw)
To: git
The cleanup of old compat wrappers in bash completion caused a
regression on tcsh completion that still uses them.
Let's update the tcsh call site as well for addressing it.
Fixes: 441ecdab37fe ("completion: bash: remove old compat wrappers")
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
contrib/completion/git-completion.tcsh | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/contrib/completion/git-completion.tcsh b/contrib/completion/git-completion.tcsh
index 4a790d8f4ec1..ba797e5b3cd5 100644
--- a/contrib/completion/git-completion.tcsh
+++ b/contrib/completion/git-completion.tcsh
@@ -80,8 +80,9 @@ else
COMP_CWORD=\$((\${#COMP_WORDS[@]}-1))
fi
-# Call _git() or _gitk() of the bash script, based on the first argument
-_\${1}
+# Call __git_wrap__git_main() or __git_wrap__gitk_main() of the bash script,
+# based on the first argument
+__git_wrap__\${1}_main
IFS=\$'\n'
if [ \${#COMPREPLY[*]} -eq 0 ]; then
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] completion: tcsh: Fix regression by drop of wrapper functions
2021-08-18 13:27 [PATCH] completion: tcsh: Fix regression by drop of wrapper functions Takashi Iwai
@ 2021-08-18 20:57 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2021-08-18 20:57 UTC (permalink / raw)
To: Takashi Iwai; +Cc: git
Takashi Iwai <tiwai@suse.de> writes:
> The cleanup of old compat wrappers in bash completion caused a
> regression on tcsh completion that still uses them.
> Let's update the tcsh call site as well for addressing it.
>
> Fixes: 441ecdab37fe ("completion: bash: remove old compat wrappers")
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
> contrib/completion/git-completion.tcsh | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Thanks. Will queue.
> diff --git a/contrib/completion/git-completion.tcsh b/contrib/completion/git-completion.tcsh
> index 4a790d8f4ec1..ba797e5b3cd5 100644
> --- a/contrib/completion/git-completion.tcsh
> +++ b/contrib/completion/git-completion.tcsh
> @@ -80,8 +80,9 @@ else
> COMP_CWORD=\$((\${#COMP_WORDS[@]}-1))
> fi
>
> -# Call _git() or _gitk() of the bash script, based on the first argument
> -_\${1}
> +# Call __git_wrap__git_main() or __git_wrap__gitk_main() of the bash script,
> +# based on the first argument
> +__git_wrap__\${1}_main
>
> IFS=\$'\n'
> if [ \${#COMPREPLY[*]} -eq 0 ]; then
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-18 20:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-18 13:27 [PATCH] completion: tcsh: Fix regression by drop of wrapper functions Takashi Iwai
2021-08-18 20:57 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).