From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Roland Hieber <rhi@pengutronix.de>,
git@vger.kernel.org, Vasco Almeida <vascomalmeida@sapo.pt>
Subject: Re: [PATCH] bisect: allow to run from subdirectories
Date: Mon, 28 Jun 2021 18:22:37 -0700 [thread overview]
Message-ID: <xmqqtulh31nm.fsf@gitster.g> (raw)
In-Reply-To: YNPGb5gvygs++jlv@coredump.intra.peff.net
Jeff King <peff@peff.net> writes:
>> This does not depend on "do we have T as a directory?" being the
>> bisection criteria. The important thing is that the current
>> directory would appear and disappear as the bisection process makes
>> you jump around in the history.
>
> I think that is a good explanation. But I remain somewhat unconvinced
> that it is that big a problem in practice.
It's just the difference in attitude, I would think. Things like
"rebase" take a more liberal attitude and most of the time things
work out OK because removal of a directory is a rare event and
replacement of a directory with a non-directory is even rarer, but
when things break there is no provision to help users to know how it
broke by diagnosing why the revision cannot be checked out, or why
the directory D the user's shell session is sitting in is now
orphaned and different from the directory D the user thinks he is in
because it was removed (while the user's process is in there) and
then recreated under the same name, or any of the tricky things.
The ideal endgame would be to allow operating from subdirectory
*AND* have provisions for helping users when things go wrong because
the starting subdirectory goes away. "bisect" works under the more
conservative philosophy (start strict and forbid operation that we
know we didn't spend any effort to avoid taking the user into
dangerous waters---we can allow it later once we make it safer but
not until then).
It would involve a bit of chicken-and-egg, I would guess. If we
think improving Git is more important than avoiding even occasional
failures imposed on end-users, then the more liberal approach would
be easier to work with---we can allow the command to start from
subdirectory even if we do not do anything to help avoid problems,
let the users hit a snag and have them report it, which would give
us some concrete failure mode to work on.
next prev parent reply other threads:[~2021-06-29 1:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-20 21:38 [PATCH] bisect: allow to run from subdirectories Roland Hieber
2021-06-21 0:35 ` Ævar Arnfjörð Bjarmason
2021-06-21 2:00 ` brian m. carlson
2021-06-21 2:10 ` Eric Sunshine
2021-06-21 9:33 ` Roland Hieber
2021-06-21 12:45 ` Ævar Arnfjörð Bjarmason
2021-06-21 20:02 ` Eric Sunshine
2021-06-22 15:27 ` Ævar Arnfjörð Bjarmason
2021-06-22 0:09 ` brian m. carlson
2021-06-21 3:43 ` Junio C Hamano
2021-06-23 23:40 ` Jeff King
2021-06-29 1:22 ` Junio C Hamano [this message]
2021-06-29 2:00 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtulh31nm.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=rhi@pengutronix.de \
--cc=vascomalmeida@sapo.pt \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).