Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Vadim Kochan <vadim4j@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/1] configure.ac: Properly check for libintl
Date: Fri, 19 Apr 2019 15:37:05 +0900	[thread overview]
Message-ID: <xmqqtveucxgu.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190419051249.oiypxcs6hexjdf2d@vkochan-ThinkPad-T470p> (Vadim Kochan's message of "Fri, 19 Apr 2019 08:12:49 +0300")

Vadim Kochan <vadim4j@gmail.com> writes:

>> I think
>> 
>> 	autoconf: #include <libintl.h> when checking for gettext()
>> 
>> is probably a better title.  
>> 
>> Together with your originally proposed log message, which we now
>> know explains why this inclusion makes a difference sufficiently to
>> be understandable by an average Git developer, the resulting commit
>> will communicate to our future developers the reason why we thought
>> this was a good change clearly.
>> 
>> Thanks.
>
> Thanks! Should I re-submit patch with title updated v2 ?

You could if you feel like it, but in a case like this, responding
with "Yeah, I agree with your suggestion" and telling me to retitle
is sufficient, if you have nothing else to change in the v2.

I've already did the retitling while queuing it, so no need to
resend.

Thanks.

      reply	other threads:[~2019-04-19 19:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-18  5:04 [PATCH 1/1] configure.ac: Properly check for libintl Vadim Kochan
2019-04-18  5:45 ` Junio C Hamano
2019-04-18  8:28   ` Vadym Kochan
2019-04-19  4:56     ` Junio C Hamano
2019-04-19  5:12       ` Vadim Kochan
2019-04-19  6:37         ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqtveucxgu.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=vadim4j@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox