From: Junio C Hamano <gitster@pobox.com>
To: Danny Lin <danny0838@gmail.com>
Cc: Ralf Thielow <ralf.thielow@gmail.com>, git <git@vger.kernel.org>
Subject: Re: [PATCH] branch: -r -d(D) should say "remote-tracking branch"
Date: Wed, 06 May 2015 13:29:01 -0700 [thread overview]
Message-ID: <xmqqtwvpsb5e.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAMbsUu4iAD0kGh_ZzbLBS4P69Hz-T4Mv0krLst+M7SVc=v=Dog@mail.gmail.com> (Danny Lin's message of "Thu, 7 May 2015 03:01:55 +0800")
Danny Lin <danny0838@gmail.com> writes:
> git branch -r -d(D) currently says "delete remote branch",
> which should be "remote-tracking branch".
>
> Signed-off-by: Danny Lin <danny0838@gmail.com>
> ---
Thanks.
The patch is whitespace damaged and does not apply, though. I
manually typed the same change and commited with a tweaked log
message, so no need to resend this one, but for future reference,
please try sending a patch to yourself and make sure it applies
cleanly (and if it doesn't, figure out where tabs are eaten and
lines are wrapped and fix that problem before sending the patch to
the list).
> builtin/branch.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/builtin/branch.c b/builtin/branch.c
> index dc6f0b2..3560c51 100644
> --- a/builtin/branch.c
> +++ b/builtin/branch.c
> @@ -242,7 +242,7 @@ static int delete_branches(int argc, const char
> **argv, int force, int kinds,
> sha1, &flags);
> if (!target) {
> error(remote_branch
> - ? _("remote branch '%s' not found.")
> + ? _("remote-tracking branch '%s' not found.")
> : _("branch '%s' not found."), bname.buf);
> ret = 1;
> continue;
> @@ -257,7 +257,7 @@ static int delete_branches(int argc, const char
> **argv, int force, int kinds,
>
> if (delete_ref(name, sha1, REF_NODEREF)) {
> error(remote_branch
> - ? _("Error deleting remote branch '%s'")
> + ? _("Error deleting remote-tracking branch '%s'")
> : _("Error deleting branch '%s'"),
> bname.buf);
> ret = 1;
> @@ -265,7 +265,7 @@ static int delete_branches(int argc, const char
> **argv, int force, int kinds,
> }
> if (!quiet) {
> printf(remote_branch
> - ? _("Deleted remote branch %s (was %s).\n")
> + ? _("Deleted remote-tracking branch %s (was %s).\n")
> : _("Deleted branch %s (was %s).\n"),
> bname.buf,
> (flags & REF_ISBROKEN) ? "broken"
prev parent reply other threads:[~2015-05-06 20:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 9:46 [PATCH] branch: -r -d(D) should say "remote-tracking branch" Danny Lin
2015-05-06 17:49 ` Ralf Thielow
2015-05-06 17:53 ` Junio C Hamano
2015-05-06 19:01 ` Danny Lin
2015-05-06 20:29 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtwvpsb5e.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=danny0838@gmail.com \
--cc=git@vger.kernel.org \
--cc=ralf.thielow@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).