From: Junio C Hamano <gitster@pobox.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH] for-each-ref: remove unused variable
Date: Mon, 30 Dec 2013 12:22:18 -0800 [thread overview]
Message-ID: <xmqqtxdqqebp.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1388420935-14030-1-git-send-email-artagnon@gmail.com> (Ramkumar Ramachandra's message of "Mon, 30 Dec 2013 21:58:55 +0530")
Ramkumar Ramachandra <artagnon@gmail.com> writes:
> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
> ---
Interesting. As far as I can tell, no code ever used this symbol
since the command was introduced at 9f613ddd (Add git-for-each-ref:
helper for language bindings, 2006-09-15).
> builtin/for-each-ref.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/builtin/for-each-ref.c b/builtin/for-each-ref.c
> index 6551e7b..51798b4 100644
> --- a/builtin/for-each-ref.c
> +++ b/builtin/for-each-ref.c
> @@ -92,7 +92,7 @@ static struct {
> */
> static const char **used_atom;
> static cmp_type *used_atom_type;
> -static int used_atom_cnt, sort_atom_limit, need_tagged, need_symref;
> +static int used_atom_cnt, need_tagged, need_symref;
> static int need_color_reset_at_eol;
>
> /*
> @@ -1105,7 +1105,6 @@ int cmd_for_each_ref(int argc, const char **argv, const char *prefix)
>
> if (!sort)
> sort = default_sort();
> - sort_atom_limit = used_atom_cnt;
>
> /* for warn_ambiguous_refs */
> git_config(git_default_config, NULL);
prev parent reply other threads:[~2013-12-30 20:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-30 16:28 [PATCH] for-each-ref: remove unused variable Ramkumar Ramachandra
2013-12-30 20:22 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtxdqqebp.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).