Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Daniel Martí" <mvdan@mvdan.cc>
Cc: "Daniel Martí via GitGitGadget" <gitgitgadget@gmail.com>,
	git@vger.kernel.org, "M Hickford" <mirth.hickford@gmail.com>,
	"Mantas Mikulėnas" <grawity@gmail.com>,
	"Patrick Steinhardt" <ps@pks.im>
Subject: Re: [PATCH] credential/libsecret: load secrets explicitly
Date: Mon, 21 Sep 2026 15:52:27 -0700	[thread overview]
Message-ID: <xmqqv77yjjys.fsf@gitster.g> (raw)
In-Reply-To: <c3f51472-8dfa-42df-aa8b-b0f5bfd0aafe@mvdan.cc> ("Daniel Martí"'s message of "Mon, 21 Sep 2026 22:54:15 +0100")

Daniel Martí <mvdan@mvdan.cc> writes:

> Friendly nudge :) Happy to look into any tweaks or questions.

We have had a review exchange.  A reviewer had to ask questions on
the points where the code and the proposed log message weren't
clear.  The ball is now in the author's court to improve the patch
to the point that the next reviewer who did not see the first
exchange would not have to ask the same questions.

Thanks for working on this topic.

  reply	other threads:[~2026-09-21 22:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-04 22:40 [PATCH] credential/libsecret: load secrets explicitly Daniel Martí via GitGitGadget
2026-08-20 15:00 ` Daniel Martí
2026-08-20 19:05   ` Junio C Hamano
2026-08-22 20:47     ` Daniel Martí
2026-09-21 21:54       ` Daniel Martí
2026-09-21 22:52         ` Junio C Hamano [this message]
2026-09-24  7:00 ` M Hickford
2026-09-27 22:45   ` Daniel Martí
2026-09-27 22:46 ` [PATCH v2] " Daniel Martí via GitGitGadget
2026-09-28  7:37   ` Daniel Martí

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqv77yjjys.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=grawity@gmail.com \
    --cc=mirth.hickford@gmail.com \
    --cc=mvdan@mvdan.cc \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox