public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Siddharth Shrimali <r.siddharth.shrimali@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] t: fix "that that" typo in lib-unicode-nfc-nfd.sh
Date: Mon, 02 Mar 2026 13:43:06 -0800	[thread overview]
Message-ID: <xmqqv7fdykk5.fsf@gitster.g> (raw)
In-Reply-To: <20260302192627.83631-1-r.siddharth.shrimali@gmail.com> (Siddharth Shrimali's message of "Tue, 3 Mar 2026 00:56:27 +0530")

Siddharth Shrimali <r.siddharth.shrimali@gmail.com> writes:

> In the comments of lib-unicode-nfc-nfd.sh, "that that" was used
> unintentionally. Remove the redundant "that" to improve clarity.

Thanks, will queue.

>
> Signed-off-by: Siddharth Shrimali <r.siddharth.shrimali@gmail.com>
> ---
> Changes since v1:
> Dropped changes to t0019 and t6416 as the original "that that" 
> phrasing in those files was grammatically intentional.
>
>  t/lib-unicode-nfc-nfd.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/lib-unicode-nfc-nfd.sh b/t/lib-unicode-nfc-nfd.sh
> index aed0a4dd44..201ab9b24c 100755
> --- a/t/lib-unicode-nfc-nfd.sh
> +++ b/t/lib-unicode-nfc-nfd.sh
> @@ -75,7 +75,7 @@ test_lazy_prereq UNICODE_NFD_PRESERVED '
>  #
>  # Note that I've used the canonical ordering of the
>  # combining characters.  It is also possible to
> -# swap them.  My testing shows that that non-standard
> +# swap them.  My testing shows that non-standard
>  # ordering also causes a collision in mkdir.  However,
>  # the resulting names don't draw correctly on the
>  # terminal (implying that the on-disk format also has

      reply	other threads:[~2026-03-02 21:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-02 16:45 [PATCH] t: fix "that that" typos in test comments Siddharth Shrimali
2026-03-02 17:00 ` Siddharth Shrimali
2026-03-02 18:46 ` Junio C Hamano
2026-03-02 19:26 ` [PATCH v2] t: fix "that that" typo in lib-unicode-nfc-nfd.sh Siddharth Shrimali
2026-03-02 21:43   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqv7fdykk5.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=r.siddharth.shrimali@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox