From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-b2-smtp.messagingengine.com (fout-b2-smtp.messagingengine.com [202.12.124.145]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B358C81720 for ; Tue, 21 Oct 2025 05:10:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.145 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761023456; cv=none; b=C2S8RwjVf+YVgFLl+Pw4WUBMGjTqpl5k03j3dtxBhK840hGy7jUVyZN3pC7d0yYNqDVeDkfV6SmYqWSzfGGaknNIVVXkyKvY8M47/QKotOLXlwaeFXPjzJEWS89rHEzbzIQSYZmQXXudLqo/vk/NawdcBeJCvmz54cz39Xt7r0o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761023456; c=relaxed/simple; bh=eHjsI2RCOaHzk7zXol71q7K6tBpOK/T/w8/P8/Ypsv0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=oCGEgvAAFeaBKGJ0o42sGdlyJYyrEBzWuu/dQ1IPXqapA/zNZQguCN/04WYJjbZZc/1UaCdJ4d4ctZBQJeHPY4Cd3n09m+3yxsk+mDddrpUzwUKIXeldZ+TQKZlXGkKIIR1QresrdEAaFflXwBlh9S9CWyr8MBWFtHInaaCGmaM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com; spf=pass smtp.mailfrom=pobox.com; dkim=pass (2048-bit key) header.d=pobox.com header.i=@pobox.com header.b=OhGAQ1a3; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=e10ULkfL; arc=none smtp.client-ip=202.12.124.145 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pobox.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pobox.com header.i=@pobox.com header.b="OhGAQ1a3"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="e10ULkfL" Received: from phl-compute-09.internal (phl-compute-09.internal [10.202.2.49]) by mailfout.stl.internal (Postfix) with ESMTP id A011A1D001BC; Tue, 21 Oct 2025 01:10:52 -0400 (EDT) Received: from phl-frontend-01 ([10.202.2.160]) by phl-compute-09.internal (MEProxy); Tue, 21 Oct 2025 01:10:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pobox.com; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1761023452; x=1761109852; bh=eHjsI2RCOa Hzk7zXol71q7K6tBpOK/T/w8/P8/Ypsv0=; b=OhGAQ1a3r5DxbYazA3fkxqNQ0a 2JnrQEjXL0e/1XTW2/itS44KF7uVKppRIrNpb73b1inzuiS0VW2nQD+vqd1wF8Vb i/dFGrQ5PnjackAXoaUFRe4ZLqxD/qLbVoIdKBEryNq+ehqwR0P2SjMYmDNTIKJi IqrGTnqQaF2jCHGAm+1Wq0prtEvcY0z2mpsnvc+Nf4/VjfRcrrBQJIhimYrKeO1N lZPnTsDR2FsQ7l93sdwm86Fo1h1QRRjD0jeVOD7dg79cZekVcTTjaLlVlDNwLuX/ HnnoefmqFK8RiA6+2IdmRVNBOWxq+tlWXvuwXf8AVMjpwytU4Z/6BEOaw/xQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1761023452; x=1761109852; bh=eHjsI2RCOaHzk7zXol71q7K6tBpOK/T/w8/ P8/Ypsv0=; b=e10ULkfLahQF2gqCrHrrY/Z/TKbGYenCL37tXAwLTeRQ7jJNRGs 8NIzeLG9Qqh82OTajPeFfitvyDK95gt2iLId6JTpQbT0pN3xUhF5KWBN27lIveYA LBUFcSSsG1VEamXwEq0iDy+HS+Ud8dBCS69VTHN60Om4L8XlfnC7+7H8M7BzINQT fQP/ZxqpR8qlZlbxtLCNSPRX2KlHiuHgCK7XKWjj/osTOub9vFfXO+GYOZeI8utM Oyz3yFZU13fgk25bcPYlrxF/FzSZs+Fi5rIJC2myZUU9yNNAnaXFuB55CdDnBlMo awBJvc2BLfKKHJ7fgZOQ8bJbTNpkCxgO+Eg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddufeelkeefucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhephffvvefujghffffkfgggtgesthdtredttdertdenucfhrhhomheplfhunhhiohcu vecujfgrmhgrnhhouceoghhithhsthgvrhesphhosghogidrtghomheqnecuggftrfgrth htvghrnhepfeevteetjeehueegffelvdetieevffeufeejleeuffetiefggfeftdfhfeei geeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepgh hithhsthgvrhesphhosghogidrtghomhdpnhgspghrtghpthhtohepgedpmhhouggvpehs mhhtphhouhhtpdhrtghpthhtohepvgiivghkihgvlhhnvgifrhgvnhesghhmrghilhdrtg homhdprhgtphhtthhopehgihhtghhithhgrggughgvthesghhmrghilhdrtghomhdprhgt phhtthhopehgihhtsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtohepghhith hsthgvrhesphhosghogidrtghomh X-ME-Proxy: Feedback-ID: if26b431b:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 21 Oct 2025 01:10:51 -0400 (EDT) From: Junio C Hamano To: Ezekiel Newren Cc: Ezekiel Newren via GitGitGadget , git@vger.kernel.org Subject: Re: [PATCH 5/9] xdiff: split xrecord_t.ha into line_hash and minimal_perfect_hash In-Reply-To: (Ezekiel Newren's message of "Mon, 20 Oct 2025 17:29:25 -0600") References: Date: Mon, 20 Oct 2025 22:10:50 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Ezekiel Newren writes: > I'm a bit surprised that nobody has commented on this patch. I thought > that someone would have criticized the length of the name > "minimal_perfect_hash" or asked me why I was splitting one field into > two. Sometimes there aren't enough round tuits to go around, and when people have been too busy to review it, we see no comment, either positive ones or negative ones. > I don't see any reason why this patch series shouldn't move forward. A patch series needs a positive reason to move forward; unfortunately we cannot tell much from lack of negative comments.