From: Junio C Hamano <gitster@pobox.com>
To: Justin Tobler <jltobler@gmail.com>
Cc: Han Young <hanyang.tony@bytedance.com>, git@vger.kernel.org
Subject: Re: [PATCH] read-cache: report lock error when refreshing index
Date: Tue, 01 Jul 2025 12:21:20 -0700 [thread overview]
Message-ID: <xmqqv7obk98v.fsf@gitster.g> (raw)
In-Reply-To: <t4czubzmfuihxzmefwwhcel5qyss35gmodhfhvkfyiwitb5osw@d33acdbtds63> (Justin Tobler's message of "Tue, 1 Jul 2025 11:08:52 -0500")
Justin Tobler <jltobler@gmail.com> writes:
>> test_must_fail git stash create 2>err &&
>> - test_cmp expect err
>> + test_grep "error: Unable to create '.*index.lock'" err
>
> The test now checks for the explicit lock error message. The check for
> the "error: could not write index" message is also removed even though
> it should still be present in the output. Should we also continue to
> grep for that message too?
Probably. I was wondering which part of the patch removed the
existing message while reading this update to the test.
Thanks.
next prev parent reply other threads:[~2025-07-01 19:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-01 11:57 [PATCH] read-cache: report lock error when refreshing index Han Young
2025-07-01 16:08 ` Justin Tobler
2025-07-01 19:21 ` Junio C Hamano [this message]
2025-07-03 7:45 ` [PATCH v2] " Han Young
2025-07-07 18:01 ` Junio C Hamano
2025-07-08 2:47 ` [External] " Han Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv7obk98v.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=hanyang.tony@bytedance.com \
--cc=jltobler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).