From: Junio C Hamano <gitster@pobox.com>
To: "Ondřej Pohořelský via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, "Ondřej Pohořelský" <opohorel@redhat.com>
Subject: Re: [PATCH v4] cvsserver: remove unused escapeRefName function
Date: Tue, 27 May 2025 08:24:59 -0700 [thread overview]
Message-ID: <xmqqv7pmqdo4.fsf@gitster.g> (raw)
In-Reply-To: <pull.1925.v4.git.1748267305871.gitgitgadget@gmail.com> ("Ondřej Pohořelský via GitGitGadget"'s message of "Mon, 26 May 2025 13:48:25 +0000")
"Ondřej Pohořelský via GitGitGadget" <gitgitgadget@gmail.com>
writes:
> Function 'escapeRefName' introduced in 51a7e6dbc9 has never been used.
>
> Despite being dead code, changes in Perl 5.41.4 exposed precedence
> warning withing its logic, which then caused test failures in t9402 by
> logging the warnings to stderr while parsing the code. The affected
> tests are t9402.30, t9402.31, t9402.32 and t9402.34.
>
> Remove this unused function to simplify the codebase and stop the
> warnings and test failures. Its corresponding unescapeRefName function,
> which remains in use, has had its comments updated.
Very clearly explained and looking good. Thanks.
Will queue with "withing" -> "within".
next prev parent reply other threads:[~2025-05-27 15:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-21 7:45 [PATCH] cvsserver: avoid precedence problem between ! and %s Ondřej Pohořelský via GitGitGadget
2025-05-21 7:53 ` Kristoffer Haugsbakk
2025-05-21 10:23 ` [PATCH v2] " Ondřej Pohořelský via GitGitGadget
2025-05-21 15:54 ` Junio C Hamano
2025-05-21 16:02 ` Junio C Hamano
2025-05-21 17:03 ` Junio C Hamano
2025-05-22 7:19 ` Ondrej Pohorelsky
2025-05-22 15:55 ` Junio C Hamano
2025-05-22 17:05 ` Jeff King
2025-05-22 17:56 ` Todd Zullinger
2025-05-22 18:51 ` Junio C Hamano
2025-05-23 4:47 ` Matthew Ogilvie
2025-05-23 15:48 ` Junio C Hamano
2025-05-26 13:56 ` Ondrej Pohorelsky
2025-05-27 15:52 ` Junio C Hamano
2025-05-22 11:26 ` [PATCH v3] " Ondřej Pohořelský via GitGitGadget
2025-05-26 13:48 ` [PATCH v4] cvsserver: remove unused escapeRefName function Ondřej Pohořelský via GitGitGadget
2025-05-27 15:24 ` Junio C Hamano [this message]
2025-05-21 14:58 ` [PATCH] cvsserver: avoid precedence problem between ! and %s Junio C Hamano
2025-05-21 21:48 ` brian m. carlson
2025-05-22 7:31 ` Ondrej Pohorelsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv7pmqdo4.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=opohorel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).