From: Junio C Hamano <gitster@pobox.com>
To: Mark Mentovai <mark@chromium.org>
Cc: Git Development <git@vger.kernel.org>,
Chandra Pratap <chandrapratap3519@gmail.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>,
Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Subject: Re: [PATCH v3 0/2] apply: set file mode when --reverse creates a deleted file
Date: Tue, 27 May 2025 06:56:03 -0700 [thread overview]
Message-ID: <xmqqv7pmrwcs.fsf@gitster.g> (raw)
In-Reply-To: <20250524034046.2619-1-mark@chromium.org> (Mark Mentovai's message of "Fri, 23 May 2025 23:40:44 -0400")
Mark Mentovai <mark@chromium.org> writes:
> Changes from v2:
> * test_file_mode_common correctly fails when requested to verify the
> presence of a file (by nonzero mode argument) that is actually absent.
> * Test setup establishes tags at appropriate checkpoints with git tag,
> and tests restore those checkpoints with git reset --hard, making
> tests less sensitive to execution order and to the success of previous
> tests.
> * test_file_mode_common accepts full 6-digit file modes instead of
> 4-digit ones, and uses 000000 for absent files (as git diff --raw
> does) instead of an empty string.
> * File presence is assured with >f as opposed to touch f. Minor style
> * fix at the point of test_file_mode_common's declaration.
Nicely done. Thanks.
Will queue.
prev parent reply other threads:[~2025-05-27 13:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-22 22:02 [PATCH] apply: set file mode when --reverse creates a deleted file Mark Mentovai
2025-05-22 22:24 ` Kristoffer Haugsbakk
2025-05-22 23:15 ` Junio C Hamano
2025-05-22 22:58 ` Junio C Hamano
2025-05-22 23:48 ` Mark Mentovai
2025-05-23 14:49 ` Junio C Hamano
2025-05-23 17:21 ` [PATCH v2 0/2] " Mark Mentovai
2025-05-23 17:21 ` [PATCH v2 1/2] t4129: test that git apply warns for unexpected mode changes Mark Mentovai
2025-05-23 23:32 ` Junio C Hamano
2025-05-24 3:10 ` Mark Mentovai
2025-05-23 17:21 ` [PATCH v2 2/2] apply: set file mode when --reverse creates a deleted file Mark Mentovai
2025-05-23 23:44 ` Junio C Hamano
2025-05-24 3:19 ` Mark Mentovai
2025-05-24 3:40 ` [PATCH v3 0/2] " Mark Mentovai
2025-05-24 3:40 ` [PATCH v3 1/2] t4129: test that git apply warns for unexpected mode changes Mark Mentovai
2025-05-24 3:40 ` [PATCH v3 2/2] apply: set file mode when --reverse creates a deleted file Mark Mentovai
2025-05-27 13:56 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv7pmrwcs.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=chandrapratap3519@gmail.com \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
--cc=kristofferhaugsbakk@fastmail.com \
--cc=mark@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).