From: Junio C Hamano <gitster@pobox.com>
To: Li Chen <me@linux.beauty>
Cc: "git" <git@vger.kernel.org>
Subject: Re: [RFC PATCH 1/2] rebase, am: add --reviewby option
Date: Tue, 06 May 2025 11:07:46 -0700 [thread overview]
Message-ID: <xmqqv7qdk3yl.fsf@gitster.g> (raw)
In-Reply-To: <196a5aceb00.fdc2d9ff187843.3547183335386278718@linux.beauty> (Li Chen's message of "Tue, 06 May 2025 20:58:15 +0800")
Li Chen <me@linux.beauty> writes:
> From: Li Chen <chenl311@chinatelecom.cn>
>
> Introduce a new `--reviewby` flag to `git rebase` and `git am` that appends a
Shouldn't this (and possibly the other one, I didn't look at the
patch text) be using the internal machinery used by interpret-trailers
so that we can do the usual "do not duplicated existing ones",
"append only at the last one is different" etc.?
I also do not think we want to see one option (like the above) for
each trailer elements (like "Reviewed-by") that is commonly used,
which would lead us to adding "--helped-by", "--acked-by", etc. to
complement this one.
next prev parent reply other threads:[~2025-05-06 18:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 12:57 [RFC PATCH 0/2] rebase: support --trailer and add --reviewby Li Chen
2025-05-06 12:58 ` [RFC PATCH 1/2] rebase, am: add --reviewby option Li Chen
2025-05-06 18:07 ` Junio C Hamano [this message]
2025-05-07 6:46 ` Li Chen
2025-05-07 10:17 ` Phillip Wood
2025-05-07 10:26 ` Phillip Wood
2025-05-07 10:39 ` Kristoffer Haugsbakk
2025-05-07 13:38 ` Phillip Wood
2025-05-07 17:39 ` Junio C Hamano
2025-05-06 12:58 ` [RFC PATCH 2/2] rebase: support --trailer Li Chen
2025-05-08 14:17 ` Phillip Wood
2025-05-08 15:55 ` Li Chen
2025-05-08 15:58 ` phillip.wood123
2025-05-08 16:29 ` Phillip Wood
2025-05-16 5:42 ` Li Chen
2025-05-16 10:04 ` Phillip Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv7qdk3yl.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=me@linux.beauty \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).