From: Junio C Hamano <gitster@pobox.com>
To: Phillip Wood <phillip.wood123@gmail.com>
Cc: Karthik Nayak <karthik.188@gmail.com>,
chriscool@tuxfamily.org, git@vger.kernel.org,
jltobler@gmail.com, toon@iotcl.com,
Patrick Steinhardt <ps@pks.im>
Subject: Re: [PATCH v5] blame: print unblamable and ignored commits in porcelain mode
Date: Mon, 07 Apr 2025 17:32:52 -0700 [thread overview]
Message-ID: <xmqqv7rfze4r.fsf@gitster.g> (raw)
In-Reply-To: <2fbecc76-c3d9-4a8e-9326-5b83db1ceb26@gmail.com> (Phillip Wood's message of "Fri, 4 Apr 2025 16:58:44 +0100")
Phillip Wood <phillip.wood123@gmail.com> writes:
> Hi Karthik
>
> On 03/04/2025 17:03, Karthik Nayak wrote:
>> The 'git-blame(1)' command allows users to ignore specific revisions via
>> the '--ignore-rev <rev>' and '--ignore-revs-file <file>' flags. These
>> flags are often combined with the 'blame.markIgnoredLines' and
>> 'blame.markUnblamableLines' config options. These config options prefix
>> ignored and unblamable lines with a '?' and '*', respectively.
>> However, this option was never extended to the porcelain mode of
>> 'git-blame(1)'. Since the documentation does not indicate this
>> exclusion, it is a bug.
>> Fix this by printing 'ignored' and 'unblamable' respectively for the
>> options when using the porcelain modes.
>
> This looks good to me
Thanks, both of you. Will replace and queue.
Let me mark the topic for 'next'.
prev parent reply other threads:[~2025-04-08 0:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-21 16:39 [PATCH] blame: fix unblamable and ignored lines in porcelain mode Karthik Nayak
2025-03-23 15:58 ` Junio C Hamano
2025-03-24 10:16 ` Patrick Steinhardt
2025-03-24 10:37 ` Toon Claes
2025-03-24 20:04 ` Karthik Nayak
2025-03-25 8:45 ` Toon Claes
2025-03-25 10:31 ` Karthik Nayak
2025-03-25 19:44 ` Junio C Hamano
2025-03-24 20:00 ` Karthik Nayak
2025-03-24 19:56 ` Karthik Nayak
2025-03-26 21:06 ` [PATCH v2] blame: print unblamable and ignored commits " Karthik Nayak
2025-03-26 22:49 ` Eric Sunshine
2025-03-27 11:07 ` Karthik Nayak
2025-03-29 19:06 ` Junio C Hamano
2025-03-28 7:00 ` Patrick Steinhardt
2025-03-29 10:26 ` Karthik Nayak
2025-03-29 18:21 ` [PATCH v3] " Karthik Nayak
2025-03-30 4:56 ` Junio C Hamano
2025-03-30 9:28 ` Phillip Wood
2025-03-30 20:43 ` [PATCH v4] " Karthik Nayak
2025-03-31 7:05 ` Patrick Steinhardt
2025-03-31 7:34 ` Karthik Nayak
2025-03-31 10:24 ` phillip.wood123
2025-03-31 10:47 ` Phillip Wood
[not found] ` <CAOLa=ZSQ7PiasRk23Hxp7Gk5vU-x83N4e4WTxG3eVsxK0zKnWA@mail.gmail.com>
[not found] ` <f39c6468-aade-489a-bc7b-c3d342a22cb8@gmail.com>
[not found] ` <CAOLa=ZQMYn2eYndX0saTKnuzAacjtNZeTb9PCrcNC50nneAq5g@mail.gmail.com>
2025-04-02 13:07 ` Phillip Wood
2025-04-03 16:03 ` [PATCH v5] " Karthik Nayak
2025-04-04 15:58 ` Phillip Wood
2025-04-08 0:32 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv7rfze4r.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=jltobler@gmail.com \
--cc=karthik.188@gmail.com \
--cc=phillip.wood123@gmail.com \
--cc=ps@pks.im \
--cc=toon@iotcl.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).