git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Arnav Bhate <bhatearnav@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Defining timestamp_t as intmax_t instead of uintmax_t
Date: Tue, 11 Mar 2025 10:28:17 -0700	[thread overview]
Message-ID: <xmqqv7sf32a6.fsf@gitster.g> (raw)
In-Reply-To: <629c3c21-ab11-42c1-8cb1-34698e736db6@gmail.com> (Arnav Bhate's message of "Tue, 11 Mar 2025 15:30:12 +0530")

Arnav Bhate <bhatearnav@gmail.com> writes:

> timestamp_t is a data type defined in git-compat-util.h as uintmax_t since
> 28f4aee3fb (use uintmax_t for timestamps, 2017-04-26). It was introduced with
> dddbad728c (timestamp_t: a new data type for timestamps, 2017-04-26) to replace
> use of both time_t and unsigned long for time-related uses.

I do not think the object format and the existing object parsers are
prepared to handle timestamp before the epoch.

You may want to go back to the list archive for discussions around
the choice of the type back then, which should have enough
information to go by.

https://lore.kernel.org/git/20170228200145.ymbqmxwrbbrwagks@sigill.intra.peff.net/

might be a good starting point.

https://lore.kernel.org/git/?q=f:peff@+d:20170201..20170430+timestamp_t

gives 6 entry points to a single large thread that may be worth
following before tackling this topic further.

Thanks.

  parent reply	other threads:[~2025-03-11 17:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-11 10:00 Defining timestamp_t as intmax_t instead of uintmax_t Arnav Bhate
2025-03-11 10:54 ` Arnav Bhate
2025-03-11 17:28 ` Junio C Hamano [this message]
2025-03-11 18:23   ` Arnav Bhate

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqv7sf32a6.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=bhatearnav@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).