From: Junio C Hamano <gitster@pobox.com>
To: "Björn Lindqvist" <bjourne@gmail.com>
Cc: phillip.wood@dunelm.org.uk, git@vger.kernel.org
Subject: Re: git rebase --continue error message is misleading
Date: Mon, 10 Feb 2025 08:59:34 -0800 [thread overview]
Message-ID: <xmqqv7thburt.fsf@gitster.g> (raw)
In-Reply-To: <CALG+76erpDGFinXsockB8=+GPEoEtd+xw=xVN1HCzv7=aFymoA@mail.gmail.com> ("Björn Lindqvist"'s message of "Mon, 10 Feb 2025 11:19:47 +0100")
Björn Lindqvist <bjourne@gmail.com> writes:
> Here, I don't think assuming the user has vi installed is correct.
Exporting GIT_EDITOR that points at the editor of your choice is
exactly for those who choose to use something else. Instead of
erroring out with "You haven't told me what editor you want to use",
editor.c has a fallback default to use DEFAULT_EDITOR that can be
configured at the compile time, and if the builder does not configure
it, then it falls back to "vi". We'd need to stop somewhere ;-)
prev parent reply other threads:[~2025-02-10 16:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 13:02 git rebase --continue error message is misleading Björn Lindqvist
2024-12-13 14:38 ` Phillip Wood
2025-02-10 10:19 ` Björn Lindqvist
2025-02-10 16:59 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv7thburt.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=bjourne@gmail.com \
--cc=git@vger.kernel.org \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).