From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: <git@vger.kernel.org>, Taylor Blau <me@ttaylorr.com>,
Patrick Steinhardt <ps@pks.im>
Subject: Re: [PATCH 2/3] ci: remove clause for Ubuntu 16.04
Date: Thu, 31 Oct 2024 17:34:14 -0700 [thread overview]
Message-ID: <xmqqv7x74ws9.fsf@gitster.g> (raw)
In-Reply-To: <20241031234934.3451390-3-sandals@crustytoothpaste.net> (brian m. carlson's message of "Thu, 31 Oct 2024 23:49:33 +0000")
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
> We're no longer testing this version and it's well beyond regular LTS
> support now, so remove the stanza for it from the case statement in our
> CI code.
Something like "we replaced it with 20.04 which does not need the
corresponding special casing" would be necessary to explain why this
is a good change, as opposed to an equally plausible-looking patch
that replaces 16.04 with 20.04 and otherwise keeps the "stanza".
> Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
> ---
> ci/install-dependencies.sh | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh
> index 126e570eb4..d30ae53a18 100755
> --- a/ci/install-dependencies.sh
> +++ b/ci/install-dependencies.sh
> @@ -55,11 +55,6 @@ ubuntu-*|ubuntu32-*)
> ${CC_PACKAGE:-${CC:-gcc}} $PYTHON_PACKAGE
>
> case "$distro" in
> - ubuntu-16.04)
> - # Does not support JGit, but we also don't really care about
> - # the others. We rather care whether Git still compiles and
> - # runs fine overall.
> - ;;
> ubuntu-*)
> mkdir --parents "$CUSTOM_PATH"
>
next prev parent reply other threads:[~2024-11-01 0:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-31 23:49 [PATCH 0/3] Improve CI testing of older systems brian m. carlson
2024-10-31 23:49 ` [PATCH 1/3] gitlab-ci: switch from Ubuntu 16.04 to 20.04 brian m. carlson
2024-10-31 23:49 ` [PATCH 2/3] ci: remove clause for Ubuntu 16.04 brian m. carlson
2024-11-01 0:34 ` Junio C Hamano [this message]
2024-11-01 0:38 ` brian m. carlson
2024-11-01 0:41 ` Junio C Hamano
2024-10-31 23:49 ` [PATCH 3/3] Add additional CI jobs to avoid accidental breakage brian m. carlson
2024-11-04 11:36 ` [PATCH 0/3] Improve CI testing of older systems Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv7x74ws9.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=ps@pks.im \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).