From: Junio C Hamano <gitster@pobox.com>
To: Ahmed Akef <aemed.akef.1@gmail.com>
Cc: ahmed akef via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, ps@pks.im
Subject: Re: [PATCH v2] docs: explain the order of output in the batched mode of git-cat-file(1)
Date: Thu, 22 Aug 2024 08:07:14 -0700 [thread overview]
Message-ID: <xmqqv7zsvbod.fsf@gitster.g> (raw)
In-Reply-To: <CAH64z8Ji59amg5Y=cBJzFKt_XiB0A5re35g9jHPWS6AoyGpRWw@mail.gmail.com> (Ahmed Akef's message of "Thu, 22 Aug 2024 09:31:57 +0200")
Ahmed Akef <aemed.akef.1@gmail.com> writes:
Administrivia: please do not break the discussion thread by dropping
In-Reply-To: and / or References: headers. For those who are
following from sidelines, this is a reponse to
https://lore.kernel.org/git/xmqqa5h5ztd9.fsf@gitster.g/
>> * "as they have been read from stdin"; drop "from stdin" here, as
>> we already know we are talking about the mode that reads object
>> names from the standard input and there is no need to repeat it.
>
> it is needed to explain that git will not do any optimization to the
> order of paths
> before printing the output.
I do not think "from stdin" is necessary for that. The sentence
begins ...
> If `--batch` or `--batch-check` is given, `cat-file` will read objects
> +from stdin, one per line, and print information about them in the same
> +order as they have been read from stdin. By default, the whole line is
> +considered as an object, as if it were fed to linkgit:git-rev-parse[1].
... by explaining that the command reads from the standard input, and
does something to each in the same order as they were read. If you
already said you are reading from the standard input, the order you
read them is the order youread them from the standard input.
Drop the "from stdin" from "as they have been read from stdin".
next prev parent reply other threads:[~2024-08-22 15:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-21 9:28 [PATCH] docs: explain the order of output in the batched mode of git-cat-file(1) ahmed akef via GitGitGadget
2024-08-21 10:05 ` [PATCH v2] " ahmed akef via GitGitGadget
2024-08-21 17:19 ` Junio C Hamano
[not found] ` <CAH64z8+dScuQbvu1aHnodE7VpCvgU2djbJhQDff76iyeFtpdTw@mail.gmail.com>
[not found] ` <CAH64z8KUWSNii_U5k5fAz3q9cu34+pOWk2Rmw-60x7iOKOD8gQ@mail.gmail.com>
2024-08-22 7:31 ` Ahmed Akef
2024-08-22 15:07 ` Junio C Hamano [this message]
2024-08-22 19:50 ` [PATCH v3] " ahmed akef via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv7zsvbod.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=aemed.akef.1@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).