From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (May 2024, #12; Tue, 28)
Date: Wed, 29 May 2024 07:24:53 -0700 [thread overview]
Message-ID: <xmqqv82w1yru.fsf@gitster.g> (raw)
In-Reply-To: <Zla7oBd7UZbPX7d8@tanuki> (Patrick Steinhardt's message of "Wed, 29 May 2024 07:22:40 +0200")
Patrick Steinhardt <ps@pks.im> writes:
> On Tue, May 28, 2024 at 03:45:05PM -0700, Junio C Hamano wrote:
>> * ps/undecided-is-not-necessarily-sha1 (2024-05-06) 15 commits
>> (merged to 'next' on 2024-05-08 at 9f8e894685)
>> + repository: stop setting SHA1 as the default object hash
>> + oss-fuzz/commit-graph: set up hash algorithm
>> + builtin/shortlog: don't set up revisions without repo
>> + builtin/diff: explicitly set hash algo when there is no repo
>> + builtin/bundle: abort "verify" early when there is no repository
>> + builtin/blame: don't access potentially unitialized `the_hash_algo`
>> + builtin/rev-parse: allow shortening to more than 40 hex characters
>> + remote-curl: fix parsing of detached SHA256 heads
>> + attr: fix BUG() when parsing attrs outside of repo
>> + attr: don't recompute default attribute source
>> + parse-options-cb: only abbreviate hashes when hash algo is known
>> + path: move `validate_headref()` to its only user
>> + path: harden validation of HEAD with non-standard hashes
>> + Merge branch 'ps/the-index-is-no-more' into ps/undecided-is-not-necessarily-sha1
>> + Merge branch 'jc/no-default-attr-tree-in-bare' into ps/undecided-is-not-necessarily-sha1
>> (this branch is used by jc/undecided-is-not-necessarily-sha1-fix.)
>>
>> Before discovering the repository details, We used to assume SHA-1
>> as the "default" hash function, which has been corrected. Hopefully
>> this will smoke out codepaths that rely on such an unwarranted
>> assumptions.
>>
>> Will cook in 'next', as it has known breakage.
>> source: <cover.1715057362.git.ps@pks.im>
>
> The follow-up patches in jc/undecided-is-not-necessarily-sha1-fix have
> landed by now, so there are no more known breakages at the current
> point, right? Do we want to merge this down now, or is there something
> you'd like me to do in this context?
I think "known breakage" is gone, but I had this on back-burner as
I wanted to forcus on cleaning up the 2.45.1 mess first X-<.
Let's unblock the topic by lifting "Will cook" mark. Thanks.
next prev parent reply other threads:[~2024-05-29 14:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 22:45 What's cooking in git.git (May 2024, #12; Tue, 28) Junio C Hamano
2024-05-29 5:22 ` Patrick Steinhardt
2024-05-29 14:24 ` Junio C Hamano [this message]
2024-05-29 8:51 ` Ghanshyam Thakkar
2024-05-29 15:03 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv82w1yru.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).