From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org, "SZEDER Gábor" <szeder.dev@gmail.com>
Subject: Re: [PATCH 3/3] t/README: document how to loop around test cases
Date: Thu, 21 Mar 2024 19:12:53 -0700 [thread overview]
Message-ID: <xmqqv85f3tga.fsf@gitster.g> (raw)
In-Reply-To: <ZfzncGTNVwR8BrhR@tanuki> (Patrick Steinhardt's message of "Fri, 22 Mar 2024 03:05:36 +0100")
Patrick Steinhardt <ps@pks.im> writes:
> Hum, good point. How about the below diff? Will reroll the patch series
> if that looks good to you.
>
> --- a/t/README
> +++ b/t/README
> @@ -736,7 +736,8 @@ The "do's:"
> done
>
> Note that while the test title uses double quotes ("), the test body
> - should continue to use single quotes ('). The loop variable will be
> + should continue to use single quotes (') to avoid breakage in case the
> + values contain e.g. quoting characters. The loop variable will be
> accessible regardless of the single quotes as the test body is passed
> to `eval`.
Wow, simple and effective.
next prev parent reply other threads:[~2024-03-22 2:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 13:47 [PATCH 0/3] t7800: fix quoting of looped test bodies Patrick Steinhardt
2024-03-21 13:47 ` [PATCH 1/3] t7800: improve test descriptions with empty arguments Patrick Steinhardt
2024-03-21 13:47 ` [PATCH 2/3] t7800: use single quotes for test bodies Patrick Steinhardt
2024-03-21 13:47 ` [PATCH 3/3] t/README: document how to loop around test cases Patrick Steinhardt
2024-03-21 17:12 ` Junio C Hamano
2024-03-22 2:05 ` Patrick Steinhardt
2024-03-22 2:12 ` Junio C Hamano [this message]
2024-03-21 13:48 ` [PATCH 0/3] t7800: fix quoting of looped test bodies Patrick Steinhardt
2024-03-22 2:23 ` [PATCH v2 " Patrick Steinhardt
2024-03-22 2:23 ` [PATCH v2 1/3] t7800: improve test descriptions with empty arguments Patrick Steinhardt
2024-03-22 2:23 ` [PATCH v2 2/3] t7800: use single quotes for test bodies Patrick Steinhardt
2024-03-22 2:23 ` [PATCH v2 3/3] t/README: document how to loop around test cases Patrick Steinhardt
2024-03-22 14:37 ` [PATCH v2 0/3] t7800: fix quoting of looped test bodies Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv85f3tga.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).