git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: "Jiří Hruška" <jirka@fud.cz>,
	git@vger.kernel.org, "Jeff King" <peff@peff.net>
Subject: Re: [PATCH] remote-curl: avoid hang if curl asks for more data after eof
Date: Tue, 14 Nov 2023 10:36:33 +0900	[thread overview]
Message-ID: <xmqqv8a515ge.fsf@gitster.g> (raw)
In-Reply-To: <20231113212243.1495815-1-jonathantanmy@google.com> (Jonathan Tan's message of "Mon, 13 Nov 2023 13:22:42 -0800")

Jonathan Tan <jonathantanmy@google.com> writes:

> Due to the nature of the bug and the fix, I do agree that it's hard to
> test and I would be OK with including the fix without associated tests.

Is this a bug on our side, or cURL library calling us when it should not?
Even if the latter, we should be prepared and the two liner fix you
suggested would be worth doing, but at the same time we should let
the cURL maintainer know if the latter is the case, and that is why
I am asking.

Thanks, both.  Especially thanks, Jonathan, for excellent review
comments.



  reply	other threads:[~2023-11-14  1:36 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-13 11:25 [PATCH] remote-curl: avoid hang if curl asks for more data after eof Jiří Hruška
2023-11-13 21:22 ` Jonathan Tan
2023-11-14  1:36   ` Junio C Hamano [this message]
2023-11-14 23:33     ` Jiří Hruška
2023-11-27 13:19       ` Jiří Hruška
2023-11-14 23:16   ` Jiří Hruška
2023-11-15  3:34 ` [PATCH v2 0/5] Avoid hang if curl needs eof twice + minor related improvements Jiří Hruška
2023-11-15 23:28   ` Jonathan Tan
2023-11-27 13:39     ` Jiří Hruška
2023-11-27 18:26       ` Jonathan Tan
     [not found] ` <20231115033121.939-1-jirka@fud.cz>
2023-11-15  3:34   ` [PATCH v2 1/5] remote-curl: avoid hang if curl asks for more data after eof Jiří Hruška
2023-11-15 19:20     ` Jonathan Tan
2023-11-15  3:34   ` [PATCH v2 2/5] remote-curl: improve readability of curl callbacks Jiří Hruška
2023-11-15  3:34   ` [PATCH v2 3/5] remote-curl: simplify rpc_out() - remove superfluous ifs Jiří Hruška
2023-11-15  3:34   ` [PATCH v2 4/5] remote-curl: simplify rpc_out() - less nesting and rename Jiří Hruška
2023-11-15  3:34   ` [PATCH v2 5/5] http: reset CURLOPT_POSTFIELDSIZE_LARGE between requests Jiří Hruška
2023-11-15  6:44     ` Patrick Steinhardt
2023-11-27 13:21       ` Jiří Hruška

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqv8a515ge.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jirka@fud.cz \
    --cc=jonathantanmy@google.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).