From: Junio C Hamano <gitster@pobox.com>
To: "Martin Ågren" <martin.agren@gmail.com>
Cc: git@vger.kernel.org, Patrick Steinhardt <ps@pks.im>
Subject: Re: [PATCH 4/4] rev-list-options: fix typo in `--stdin` documentation
Date: Wed, 16 Aug 2023 11:52:19 -0700 [thread overview]
Message-ID: <xmqqv8dees64.fsf@gitster.g> (raw)
In-Reply-To: <xmqqzg2qesoq.fsf@gitster.g> (Junio C. Hamano's message of "Wed, 16 Aug 2023 11:41:09 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> Martin Ågren <martin.agren@gmail.com> writes:
>
>> With `--stdin`, we read *from* standard input, not *for*.
>
> True, and the name of the stream is "the standard input".
... but there are too numerous instances of unadorned "standard
input" in the documentation, let's leave it for now.
Thanks for these fixes. Queued all four and will fast track.
>
>> Signed-off-by: Martin Ågren <martin.agren@gmail.com>
>> ---
>> Documentation/rev-list-options.txt | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/rev-list-options.txt b/Documentation/rev-list-options.txt
>> index e6468bf0eb..a4a0cb93b2 100644
>> --- a/Documentation/rev-list-options.txt
>> +++ b/Documentation/rev-list-options.txt
>> @@ -237,7 +237,7 @@ endif::git-rev-list[]
>>
>> --stdin::
>> In addition to getting arguments from the command line, read
>> - them for standard input as well. This accepts commits and
>> + them from standard input as well. This accepts commits and
>> pseudo-options like `--all` and `--glob=`. When a `--` separator
>> is seen, the following input is treated as paths and used to
>> limit the result.
next prev parent reply other threads:[~2023-08-16 18:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 14:24 [PATCH 0/4] some doc fixes on v2.42.0-rc2 Martin Ågren
2023-08-16 14:24 ` [PATCH 1/4] notes doc: split up run-on sentences Martin Ågren
2023-08-17 2:22 ` Teng Long
2023-08-16 14:24 ` [PATCH 2/4] notes doc: tidy up `--no-stripspace` paragraph Martin Ågren
2023-08-17 2:52 ` Teng Long
2023-08-17 6:52 ` Martin Ågren
2023-08-16 14:24 ` [PATCH 3/4] show-ref doc: fix carets in monospace Martin Ågren
2023-08-16 14:24 ` [PATCH 4/4] rev-list-options: fix typo in `--stdin` documentation Martin Ågren
2023-08-16 18:41 ` Junio C Hamano
2023-08-16 18:52 ` Junio C Hamano [this message]
2023-08-17 6:51 ` Martin Ågren
2023-08-16 18:35 ` [PATCH 0/4] some doc fixes on v2.42.0-rc2 Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv8dees64.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=martin.agren@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).