git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Andy Koppe <andy.koppe@gmail.com>
Cc: git@vger.kernel.org, pclouds@gmail.com
Subject: Re: [PATCH] log: omit tag prefix for color decoration
Date: Mon, 20 Feb 2023 13:36:54 -0800	[thread overview]
Message-ID: <xmqqv8jwggsp.fsf@gitster.g> (raw)
In-Reply-To: <20230219174631.1040-1-andy.koppe@gmail.com> (Andy Koppe's message of "Sun, 19 Feb 2023 17:46:30 +0000")

Andy Koppe <andy.koppe@gmail.com> writes:

> Omit the "tag: " prefix for tags in commit decorations when coloring is
> enabled. The prefix isn't necessary as such when tags are distinguished
> by color already, and omitting it saves a bit of space and visual noise.

As somebody whose color perception is weaker than other people, I am
torn about this line of changes.  Accessibiilty folks often warn us
against designing UI that differentiates two things only by painting
them in two different colors "to be inclusive", and the above goes
directly against their guidelines.

The only saving grace in this case is that I expect that tags are
named very differently from topics in well managed projects, and
users can tell withotu "tag:" prefix even in the output without
colors, and that si why I said "I am torn", not I am not outright
100% negative, but still I doubt that the upside of shortening 4
display spaces is worth going directly against inclusion advocates.

So...

  reply	other threads:[~2023-02-20 21:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-19 17:46 [PATCH] log: omit tag prefix for color decoration Andy Koppe
2023-02-20 21:36 ` Junio C Hamano [this message]
2023-02-21 21:28   ` Andy Koppe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqv8jwggsp.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=andy.koppe@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).