From: Junio C Hamano <gitster@pobox.com>
To: Tzadik Vanderhoof <tzadik.vanderhoof@gmail.com>
Cc: "Git List" <git@vger.kernel.org>, "Tao Klerks" <tao@klerks.biz>,
"Luke Diamand" <luke@diamand.org>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Dorgon Chang" <dorgonman@hotmail.com>,
"Joachim Kuebart" <joachim.kuebart@gmail.com>,
"Daniel Levin" <dendy.ua@gmail.com>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Ben Keene" <seraphire@gmail.com>,
"Andrew Oakley" <andrew@adoakley.name>
Subject: Re: [PATCH] git-p4: preserve utf8 BOM when importing from p4 to git
Date: Wed, 14 Dec 2022 17:29:15 +0900 [thread overview]
Message-ID: <xmqqv8mewfqc.fsf@gitster.g> (raw)
In-Reply-To: CAKu1iLWvd+PVOK405Q+SNDyyYnhbi=LtovZvWw55y6eQqoRpaA@mail.gmail.com
Tzadik Vanderhoof <tzadik.vanderhoof@gmail.com> writes:
> I propose rolling back the patch that introduced this behavior, and if
> that is not possible, I would like to submit a patch that adds a new
> setting in the "git-p4" section that will enable users to opt out of
> this new behavior (for example a boolean setting "git-p4.noUtf8Bom").
If a change in the most recent broke P4 users who have happily been
using "git p4", then we definitely should do both. Immediately
revert in preparation for Git 2.39.1 or Git 2.39.2, while working to
reintroduce it as a separate option to allow the feature to add BOM
automatically to please users like Tao.
But for such a resolution, this report should have come while
fbe5f6b8 (git-p4: preserve utf8 BOM when importing from p4 to git,
2022-04-04) was still in flight, before it was merged for e4a4b315
(Git 2.37, 2022-06-27). We had three months to do so, and now it is
way too late.
next prev parent reply other threads:[~2022-12-14 8:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 6:10 [PATCH] git-p4: preserve utf8 BOM when importing from p4 to git Tzadik Vanderhoof
2022-12-14 8:29 ` Junio C Hamano [this message]
2022-12-14 18:24 ` Tao Klerks
2022-12-14 23:11 ` Junio C Hamano
2022-12-19 9:09 ` Tao Klerks
2022-12-22 8:26 ` Tao Klerks
-- strict thread matches above, loose matches on Subject: below --
2022-04-04 5:50 Tao Klerks via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv8mewfqc.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=andrew@adoakley.name \
--cc=avarab@gmail.com \
--cc=dendy.ua@gmail.com \
--cc=dorgonman@hotmail.com \
--cc=git@vger.kernel.org \
--cc=joachim.kuebart@gmail.com \
--cc=luke@diamand.org \
--cc=seraphire@gmail.com \
--cc=sunshine@sunshineco.com \
--cc=tao@klerks.biz \
--cc=tzadik.vanderhoof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).