From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] tests: fix incorrect --write-junit-xml code
Date: Mon, 08 Aug 2022 09:47:36 -0700 [thread overview]
Message-ID: <xmqqv8r2smvr.fsf@gitster.g> (raw)
In-Reply-To: <s4s2qr56-2948-p025-rrq7-qq56p9oo844r@tzk.qr> (Johannes Schindelin's message of "Mon, 8 Aug 2022 15:40:09 +0200 (CEST)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> I still think that we need to slow the heck down with refactoring for
> refactoring's sake because it's not only the CI builds that are affected.
> I pay a lot of time to accommodate for those refactorings, and so do
> others, and the benefit of most of those refactorings escapes me.
Absolutely.
> You asked me in private to provide more reviews for those refactorings so
> that they see some push-back, but I lack the bandwidth for that.
I do remember telling you to push back what you do not want to see
in 'seen' and advance to 'next'. If everybody lacks the bandwidth
for shooting down bad ideas and only has time to promote their own
ideas, which are not guaranteed to be good ones, it does not lead
to a good place X-<.
next prev parent reply other threads:[~2022-08-08 16:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 9:00 [PATCH] tests: fix incorrect --write-junit-xml code Johannes Schindelin via GitGitGadget
2022-07-14 16:14 ` Junio C Hamano
2022-07-15 9:25 ` Ævar Arnfjörð Bjarmason
2022-08-08 13:40 ` Johannes Schindelin
2022-08-08 16:47 ` Junio C Hamano [this message]
2022-08-09 8:42 ` Johannes Schindelin
2022-08-10 18:44 ` Junio C Hamano
2022-08-12 21:00 ` Johannes Schindelin
2022-07-15 9:35 ` never refactor v.s. testing (was: [PATCH] tests: fix incorrect --write-junit-xml code) Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv8r2smvr.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).