From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Han Xin" <chiyutianyi@gmail.com>,
"Git List" <git@vger.kernel.org>,
"Han Xin" <hanxin.hx@alibaba-inc.com>
Subject: Re: [PATCH v2] receive-pack: not receive pack file with large object
Date: Fri, 01 Oct 2021 11:43:33 -0700 [thread overview]
Message-ID: <xmqqv92g7fhm.fsf@gitster.g> (raw)
In-Reply-To: <YVaw6agcPNclhws8@coredump.intra.peff.net> (Jeff King's message of "Fri, 1 Oct 2021 02:55:37 -0400")
Jeff King <peff@peff.net> writes:
> Unlike the patches here, ours is limiting the logical size of an object
> (so a 100MB blob limit is on the uncompressed size). It happens in
> sha1_object(), where we have that size.
I like it when I hear people doing things in the "right" way (the
definition of being "right" in this case is to apply the limit to
the size that is end-user facing---otherwise you cannot justify an
arbitrary limit). ;-)
next prev parent reply other threads:[~2021-10-01 18:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 12:10 [PATCH] receive-pack: allow a maximum input object size specified Han Xin
2021-09-30 13:20 ` [PATCH v2] receive-pack: not receive pack file with large object Han Xin
2021-09-30 13:42 ` Ævar Arnfjörð Bjarmason
2021-10-01 2:30 ` Jiang Xin
2021-10-01 6:17 ` Jeff King
2021-10-01 6:55 ` Jeff King
2021-10-01 18:43 ` Junio C Hamano [this message]
2021-09-30 16:49 ` Junio C Hamano
2021-10-01 2:52 ` Jiang Xin
2021-10-01 6:24 ` Jeff King
-- strict thread matches above, loose matches on Subject: below --
2021-10-01 9:16 [PATCH v10 17/17] fsck: report invalid object type-path combinations Ævar Arnfjörð Bjarmason
2021-11-11 3:03 ` [PATCH v2] receive-pack: not receive pack file with large object Han Xin
2021-11-11 18:35 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv92g7fhm.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=chiyutianyi@gmail.com \
--cc=git@vger.kernel.org \
--cc=hanxin.hx@alibaba-inc.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).