From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC PATCH v2 0/4] Avoid ls-refs when possible in protocol v2
Date: Thu, 27 Sep 2018 13:53:05 -0700 [thread overview]
Message-ID: <xmqqva6qfyry.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <cover.1538075680.git.jonathantanmy@google.com> (Jonathan Tan's message of "Thu, 27 Sep 2018 12:24:03 -0700")
Jonathan Tan <jonathantanmy@google.com> writes:
> To answer Junio's questions in [1], I think it's best to include the
> full patch set that I'm developing, so here it is. The original patch is
> now patch 3 of this set.
Yeah, taking it out of context did make its purpose fuzzy. Without
the other patches in the series that set the overall direction of
reducing ls-refs, it was unclear why some transports are marked to
specifically want to automatically call transport_get_remote_refs().
With these surrounding changes, "we call it as needed, because an
earlier step may not have called it" starts to sound quite sensible.
prev parent reply other threads:[~2018-09-27 20:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 22:53 [RFC PATCH] transport: list refs before fetch if necessary Jonathan Tan
2018-09-25 23:09 ` Junio C Hamano
2018-09-27 19:24 ` [RFC PATCH v2 0/4] Avoid ls-refs when possible in protocol v2 Jonathan Tan
2018-09-27 19:24 ` [RFC PATCH v2 1/4] transport: allow skipping of ref listing Jonathan Tan
2018-09-27 19:24 ` [RFC PATCH v2 2/4] transport: do not list refs if possible Jonathan Tan
2018-09-27 21:38 ` Stefan Beller
2018-10-07 0:53 ` Junio C Hamano
2018-09-27 19:24 ` [RFC PATCH v2 3/4] transport: list refs before fetch if necessary Jonathan Tan
2018-09-27 19:24 ` [RFC PATCH v2 4/4] fetch: do not list refs if fetching only hashes Jonathan Tan
2018-09-27 21:43 ` Stefan Beller
2018-09-28 17:50 ` Jonathan Tan
2018-09-27 20:53 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqva6qfyry.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).