From: Junio C Hamano <gitster@pobox.com>
To: Luke Shumaker <lukeshu@sbcglobal.net>
Cc: git@vger.kernel.org, pclouds@gmail.com, peff@peff.net
Subject: Re: [PATCH] daemon, path.c: fix a bug with ~ in repo paths
Date: Tue, 18 Oct 2016 10:08:45 -0700 [thread overview]
Message-ID: <xmqqvawppote.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20161018150629.23205-1-lukeshu@sbcglobal.net> (Luke Shumaker's message of "Tue, 18 Oct 2016 11:06:29 -0400")
Luke Shumaker <lukeshu@sbcglobal.net> writes:
> The superficial aspect of this change is that git-daemon now allows paths
> that start with a "~". Previously, if git-daemon was run with
> "--base-path=/srv/git", it was impossible to get it to serve
> "/srv/git/~foo/bar.git".
I am not sure I understand what you are saying here. Do you mean
I have a path on my server /srv/git/~foo/bar.git; the tilde does
not mean anything special--it is just a byte in a valid pathname.
I want to allow my users to say
git fetch git://my.server/~foo/bar.git
and fetch from that repository, but "git daemon" lacks the way
to configure to allow it.
If that is the case, what happens instead? Due to the leading
"~foo/" getting noticed as an attempt to use the user-path expansion
it is not treated as just a literal character?
I am not sure if it is even a bug. As you can easily lose that
tilde that appears in front of subdirectory of /srv/git/ or replace
it with something else (e.g. "u/"), this smells like "Don't do it if
it hurts" thing to me.
next prev parent reply other threads:[~2016-10-18 17:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 15:06 [PATCH] daemon, path.c: fix a bug with ~ in repo paths Luke Shumaker
2016-10-18 17:08 ` Junio C Hamano [this message]
2016-10-18 18:05 ` Luke Shumaker
2016-10-19 14:12 ` Duy Nguyen
2016-10-21 15:58 ` Junio C Hamano
2016-10-21 18:23 ` Junio C Hamano
2016-10-22 3:26 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqvawppote.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=lukeshu@sbcglobal.net \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).