Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Chris Packham <judge.packham@gmail.com>
Cc: GIT <git@vger.kernel.org>
Subject: Re: [BUG?] applypatch-msg hook no-longer thinks stdin is a tty
Date: Fri, 02 Oct 2015 09:03:36 -0700	[thread overview]
Message-ID: <xmqqvbap5kbr.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAFOYHZArBv=2E_YonCqOSC4mWk9=xkbG9FyB+zNFFAqmUBUKHA@mail.gmail.com> (Chris Packham's message of "Thu, 1 Oct 2015 16:42:58 +1300")

Chris Packham <judge.packham@gmail.com> writes:

> As of git 2.6 this has stopped working and stdin always fails the tty
> check.

We now run that hook thru run_hook_ve(), which closes the standard
input (as the hook is not reading anything).  Perhaps you can check
if your output is connected to the tty instead?

  reply	other threads:[~2015-10-02 16:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-01  3:42 [BUG?] applypatch-msg hook no-longer thinks stdin is a tty Chris Packham
2015-10-02 16:03 ` Junio C Hamano [this message]
2015-10-02 17:43   ` Junio C Hamano
2015-10-03  7:37     ` Chris Packham
2015-10-03  9:08       ` Johannes Sixt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqvbap5kbr.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=judge.packham@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox