From: Junio C Hamano <gitster@pobox.com>
To: Sandy Carter <sandy.carter@savoirfairelinux.com>
Cc: git@vger.kernel.org, "Raphael Hertzog" <hertzog@debian.org>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Jonathan Nieder" <jrnieder@gmail.com>
Subject: Re: [PATCH] wt-status: i18n of section labels
Date: Thu, 13 Mar 2014 11:01:52 -0700 [thread overview]
Message-ID: <xmqqvbviht9r.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <5320C0DD.1090803@savoirfairelinux.com> (Sandy Carter's message of "Wed, 12 Mar 2014 16:17:33 -0400")
Sandy Carter <sandy.carter@savoirfairelinux.com> writes:
> I refered to the wrong lines, the ones I was refering to were:
>
>> +static int maxwidth(const char *(*label)(int), int minval, int maxval)
>> +{
>> + int result = 0, i;
>> +
>> + for (i = minval; i <= maxval; i++) {
>> + const char *s = label(i);
>> + int len = s ? utf8_strwidth(s) : 0;
>
> Sorry about that
Oh, yes, you are right. wt_status_diff_status_string() is meant to
be asked with a bogus status character and expected to return NULL,
so diagnosing anything it does not understand as a "bug" is indeed a
bug I added.
I think I fixed in my latest reroll ($gmane/243996).
Thanks for catching that.
prev parent reply other threads:[~2014-03-13 18:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20131008085036.11434.25160.reportbug@x230-buxy.home.ouaza.com>
[not found] ` <20131219104613.GA18379@x230-buxy.home.ouaza.com>
2013-12-19 19:43 ` git: problematic git status output with some translations (such as fr_FR) Jonathan Nieder
2013-12-19 20:46 ` Junio C Hamano
2013-12-19 20:50 ` Jonathan Nieder
2013-12-19 23:59 ` Duy Nguyen
2014-01-16 22:00 ` Raphael Hertzog
2014-02-08 9:51 ` Duy Nguyen
2014-03-12 18:53 ` Junio C Hamano
2014-03-12 19:22 ` [PATCH] wt-status: i18n of section labels Junio C Hamano
2014-03-12 20:05 ` Sandy Carter
2014-03-12 20:12 ` Junio C Hamano
2014-03-12 20:17 ` Sandy Carter
2014-03-13 18:01 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqvbviht9r.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=hertzog@debian.org \
--cc=jrnieder@gmail.com \
--cc=pclouds@gmail.com \
--cc=sandy.carter@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).