git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Tanay Abhra <tanayabh@gmail.com>
Cc: git@vger.kernel.org, mhagger@alum.mit.edu, max@quendi.de
Subject: Re: [PATCH v4] commit.c: use skip_prefix() instead of starts_with()
Date: Tue, 04 Mar 2014 14:11:15 -0800	[thread overview]
Message-ID: <xmqqvbvtiph8.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <xmqqzjl5iro0.fsf@gitster.dls.corp.google.com> (Junio C. Hamano's message of "Tue, 04 Mar 2014 13:23:59 -0800")

Junio C Hamano <gitster@pobox.com> writes:

>> +		found = skip_prefix(buf, sigcheck_gpg_status[i].check + 1);
>> +		if(!found) {

Missing SP between the control keyword and parenthesized expression
the keyword uses.

I've fixed this (and the broken indentation) locally and queued the
result to 'pu', so no need to resend to correct this one.

Thanks.

  reply	other threads:[~2014-03-04 22:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-04 21:06 [PATCH v4] commit.c: use skip_prefix() instead of starts_with() Tanay Abhra
2014-03-04 21:23 ` Junio C Hamano
2014-03-04 22:11   ` Junio C Hamano [this message]
2014-03-04 22:32     ` Tanay Abhra
     [not found]     ` <CAEc54XB3hdsJcO4QFuqFHi+mZtZDrV2wFdMQ1uHiPrxzfo99jw@mail.gmail.com>
2014-03-05 22:23       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqvbvtiph8.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=max@quendi.de \
    --cc=mhagger@alum.mit.edu \
    --cc=tanayabh@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).