From: Junio C Hamano <gitster@pobox.com>
To: Usman Akinyemi <usmanakinyemi202@gmail.com>
Cc: Okhuomon Ajayi <okhuomonajayi54@gmail.com>,
git@vger.kernel.org, christian.couder@gmail.com,
siddharthasthana31@gmail.com, kaartic.sivaraam@gmail.com
Subject: Re: [Outreachy PATCH] merge-blobs: stop using the_repository
Date: Tue, 20 Oct 2026 14:54:28 -0700 [thread overview]
Message-ID: <xmqqwlrcrqaz.fsf@gitster.g> (raw)
In-Reply-To: <CAPSxiM-OyrVEzYgja0nwa8PikfU1WpsCYbiNiXpcxb4TM4=mOA@mail.gmail.com> (Usman Akinyemi's message of "Tue, 20 Oct 2026 17:53:02 +0100")
Usman Akinyemi <usmanakinyemi202@gmail.com> writes:
>> +static int fill_mmfile_blob(struct repository *r, mmfile_t *f,
>> + struct blob *obj)
>
> Is there a reason why the repo variable is named "r" instead of repo ?
>
> "repo" seems more "descriptive" than "r". if there is no reason, let's change
> it to "repo" from "r"
Is that really needed?
I thought that we already use short-and-sweet "r" elsewhere, and it
is expected we will have many more functions that take "struct
repository *" as the first parameter as the libification stuff goes
further, so if we consistently say "r", that would be just familiar
and descriptive as "repository" to our developers, without risking
to make readers wonder what "repo" stands for, things other than
"repository", like "reposses" ;-).
next prev parent reply other threads:[~2026-10-20 21:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-17 10:52 [Outreachy PATCH] merge-blobs: stop using the_repository Okhuomon Ajayi
2026-10-20 16:53 ` Usman Akinyemi
2026-10-20 21:41 ` Okhuomon Ajayi
2026-10-20 21:54 ` Junio C Hamano [this message]
2026-10-20 22:16 ` Usman Akinyemi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwlrcrqaz.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=kaartic.sivaraam@gmail.com \
--cc=okhuomonajayi54@gmail.com \
--cc=siddharthasthana31@gmail.com \
--cc=usmanakinyemi202@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox