public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Josh Steadmon <steadmon@google.com>
Cc: Pushkar Singh <pushkarkumarsingh1970@gmail.com>,  git@vger.kernel.org
Subject: Re: [PATCH v3] subtree: validate --prefix against commit in split
Date: Mon, 02 Feb 2026 11:10:33 -0800	[thread overview]
Message-ID: <xmqqwm0vx8pi.fsf@gitster.g> (raw)
In-Reply-To: <7k7ewvrb5hj3jyesiigy6dvo5w5pl67rk7ihztsuxbtqpymafv@ey64nvhzhacg> (Josh Steadmon's message of "Mon, 2 Feb 2026 10:54:13 -0800")

Josh Steadmon <steadmon@google.com> writes:

> Unfortunately, it seems this patch breaks the subtree tests. We noticed
> a failure in our build system at $WORK, and I was able to bisect the
> failure to this commit:
>
> $ git bisect start 54b18a3513eed9ed5ced5c238ade55a434fd619a 66b2238f5c17644ddf15f75a53c76faeca6d9f1e
> $ git bisect run sh -c 'make && make -C contrib/subtree && make -C contrib/subtree test'
>
> The tests fail on case 17 - split requires path given by option --prefix
> must exist.

Thanks for a quick regression report while it is still in 'next', so
that we can revert it out of 'next' without breaking the 'master'.

  reply	other threads:[~2026-02-02 19:10 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-15 12:09 [PATCH] subtree: validate --prefix against commit in split Pushkar Singh
2026-01-15 12:24 ` [PATCH v2] " Pushkar Singh
2026-01-15 16:30   ` Junio C Hamano
2026-01-15 17:52     ` [PATCH v3] " Pushkar Singh
2026-02-02 18:54       ` Josh Steadmon
2026-02-02 19:10         ` Junio C Hamano [this message]
2026-02-02 21:07         ` Junio C Hamano
2026-02-03 15:30           ` [RFH] adding test coverage for contrib/ in CI jobs Junio C Hamano
2026-02-03 17:06             ` Re* " Junio C Hamano
2026-02-03 23:09               ` Junio C Hamano
2026-02-04  4:38               ` Colin Stagner
2026-02-04 19:55                 ` Junio C Hamano
2026-02-05  6:05               ` Colin Stagner
2026-02-05 16:39                 ` Junio C Hamano
2026-02-05 20:54                   ` Junio C Hamano
2026-02-03 21:26             ` Junio C Hamano
2026-02-03 21:53               ` Jeff King
2026-02-03 16:48       ` [PATCH v4] subtree: validate --prefix against commit in split Pushkar Singh
2026-02-03 17:37         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqwm0vx8pi.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=pushkarkumarsingh1970@gmail.com \
    --cc=steadmon@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox