From: Junio C Hamano <gitster@pobox.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: Alex Mironov via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Alex Mironov <alexandrfox@gmail.com>
Subject: Re: [PATCH] name-hash: don't add sparse directories in threaded lazy init
Date: Wed, 21 May 2025 11:32:10 -0700 [thread overview]
Message-ID: <xmqqwma9ak7p.fsf@gitster.g> (raw)
In-Reply-To: <9c26d844-6ac5-449b-a5ff-a842ed6ba8b9@gmail.com> (Derrick Stolee's message of "Wed, 21 May 2025 13:17:08 -0400")
Derrick Stolee <stolee@gmail.com> writes:
> This seems to be a performance-only fix, ...
Hmph, then the proposed log message is phrased in a slightly
misleading way. I took that "should not" below ...
> Sparse directory entries represent a directory that is outside the
> sparse-checkout definition. These are not paths to blobs, so should not
> be added to the name_hash table as they must never be queried.
... to be saying that we would find something we should not find
when querying the name_hash table if we didn't omit them, and the
change is done for correctness.
Thanks for a quick review. Very much appreciated.
next prev parent reply other threads:[~2025-05-21 18:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-21 11:40 [PATCH] name-hash: don't add sparse directories in threaded lazy init Alex Mironov via GitGitGadget
2025-05-21 17:17 ` Derrick Stolee
2025-05-21 18:32 ` Junio C Hamano [this message]
2025-05-21 20:07 ` Alex Mironov
2025-05-21 20:16 ` [PATCH v2] " Alex Mironov via GitGitGadget
2025-05-21 20:32 ` Junio C Hamano
2025-05-21 20:37 ` Alex Mironov
2025-05-21 21:12 ` Junio C Hamano
2025-05-21 21:23 ` Junio C Hamano
2025-05-21 21:40 ` Alex Mironov
2025-05-21 21:29 ` [PATCH v3] " Alex Mironov via GitGitGadget
2025-05-21 21:47 ` Junio C Hamano
2025-05-22 1:48 ` Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwma9ak7p.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=alexandrfox@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).