git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Julian Prein via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org,  Julian Prein <julian@druckdev.xyz>
Subject: Re: [PATCH] config.txt: add trailer.* variables
Date: Fri, 24 Jan 2025 09:44:09 -0800	[thread overview]
Message-ID: <xmqqwmekyumu.fsf@gitster.g> (raw)
In-Reply-To: <CAPig+cTj5Rwp8=KA-r6SkZaf=VpqSieD-p2FgGFoMW2zmnr0Uw@mail.gmail.com> (Eric Sunshine's message of "Fri, 24 Jan 2025 10:48:52 -0500")

Eric Sunshine <sunshine@sunshineco.com> writes:

> On Thu, Jan 9, 2025 at 8:25 AM Julian Prein via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
>> The trailer.* configuration variables are currently only described in
>> git-interpret-trailers(1) but affect git-commit and git-tag as well.
>> Move that section into its own config/trailer.txt file and also include
>> it in git-config(1).
>
> Makes sense. git-commit.txt and git-tag.txt do indeed reference these
> variables, and one would expect them to be mentioned by
> Documentation/config.txt, as well.
>
>> Signed-off-by: Julian Prein <julian@druckdev.xyz>
>> ---
>> diff --git a/Documentation/config.txt b/Documentation/config.txt
>> @@ -540,6 +540,8 @@ include::config/tar.txt[]
>>  include::config/trace2.txt[]
>>
>> +include::config/trailer.txt[]
>> +
>>  include::config/transfer.txt[]
>
> Nice to see that you maintained alphabetical ordering here[*].
>
> [*]: 5f78d52dce (docs: sort configuration variable groupings
> alphabetically, 2024-02-29)

Thanks for reviewing carefully.

      reply	other threads:[~2025-01-24 17:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-09 13:25 [PATCH] config.txt: add trailer.* variables Julian Prein via GitGitGadget
2025-01-24 15:39 ` Julian Prein
2025-01-24 15:48 ` Eric Sunshine
2025-01-24 17:44   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqwmekyumu.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=julian@druckdev.xyz \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).