From: Junio C Hamano <gitster@pobox.com>
To: Josh Steadmon <steadmon@google.com>
Cc: Jonathan Tan <jonathantanmy@google.com>,
git@vger.kernel.org, hanyang.tony@bytedance.com
Subject: Re: [PATCH 0/3] Performance improvements for repacking non-promisor objects
Date: Tue, 03 Dec 2024 13:09:32 +0900 [thread overview]
Message-ID: <xmqqwmghe7b7.fsf@gitster.g> (raw)
In-Reply-To: <s6adlnfgts43vamiyzdjbjk7bqwy4gvudskclr76uunkgyktbp@pziio343f43z> (Josh Steadmon's message of "Mon, 2 Dec 2024 13:25:20 -0800")
Josh Steadmon <steadmon@google.com> writes:
>> Thanks in advance to everyone who reviews. While review is going on,
>> we'll also be testing these at $DAYJOB (I've tested it to work on one
>> known big repo, but there may be others).
>>
>> [1] https://lore.kernel.org/git/cover.1730491845.git.jonathantanmy@google.com/
>>
>> Jonathan Tan (3):
>> index-pack: dedup first during outgoing link check
>> index-pack: no blobs during outgoing link check
>> index-pack: commit tree during outgoing link check
>>
>> builtin/index-pack.c | 49 +++++++++++++++++++++++---------------------
>> 1 file changed, 26 insertions(+), 23 deletions(-)
>>
>> --
>> 2.47.0.338.g60cca15819-goog
>>
>>
>
> This series looks good to me, thanks!
>
> Reviewed-by: Josh Steadmon <steadmon@google.com>
Thanks.
next prev parent reply other threads:[~2024-12-03 4:09 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 20:18 [PATCH 0/3] Performance improvements for repacking non-promisor objects Jonathan Tan
2024-12-02 20:18 ` [PATCH 1/3] index-pack: dedup first during outgoing link check Jonathan Tan
2024-12-02 21:24 ` Josh Steadmon
2024-12-02 20:18 ` [PATCH 2/3] index-pack: no blobs " Jonathan Tan
2024-12-03 6:00 ` Patrick Steinhardt
2024-12-03 21:40 ` Jonathan Tan
2024-12-03 22:16 ` Junio C Hamano
2024-12-02 20:18 ` [PATCH 3/3] index-pack: commit tree " Jonathan Tan
2024-12-03 3:10 ` Junio C Hamano
2024-12-03 21:42 ` Jonathan Tan
2024-12-04 0:21 ` Junio C Hamano
2024-12-09 20:29 ` Jonathan Tan
2024-12-09 23:51 ` Junio C Hamano
2024-12-02 21:25 ` [PATCH 0/3] Performance improvements for repacking non-promisor objects Josh Steadmon
2024-12-03 4:09 ` Junio C Hamano [this message]
2024-12-03 4:18 ` Junio C Hamano
2024-12-03 4:20 ` Junio C Hamano
2024-12-03 4:39 ` Junio C Hamano
2024-12-03 21:43 ` [PATCH v2 " Jonathan Tan
2024-12-03 21:43 ` [PATCH v2 1/3] index-pack --promisor: dedup before checking links Jonathan Tan
2024-12-03 21:43 ` [PATCH v2 2/3] index-pack --promisor: don't check blobs Jonathan Tan
2024-12-03 21:43 ` [PATCH v2 3/3] index-pack --promisor: also check commits' trees Jonathan Tan
2024-12-03 21:52 ` [PATCH v3 0/3] Performance improvements for repacking non-promisor objects Jonathan Tan
2024-12-03 21:52 ` [PATCH v3 1/3] index-pack --promisor: dedup before checking links Jonathan Tan
2024-12-04 4:36 ` Junio C Hamano
2024-12-03 21:52 ` [PATCH v3 2/3] index-pack --promisor: don't check blobs Jonathan Tan
2024-12-03 21:52 ` [PATCH v3 3/3] index-pack --promisor: also check commits' trees Jonathan Tan
2024-12-04 2:22 ` [PATCH v3 0/3] Performance improvements for repacking non-promisor objects Junio C Hamano
2024-12-04 4:46 ` [PATCH 4/3] index-pack: work around false positive use of uninitialized variable Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwmghe7b7.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=hanyang.tony@bytedance.com \
--cc=jonathantanmy@google.com \
--cc=steadmon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).