git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org,
	 Johannes Schindelin <johannes.schindelin@gmx.de>,
	Taylor Blau <me@ttaylorr.com>,
	 Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>,
	 Johannes Sixt <j6t@kdbg.org>
Subject: Re: [PATCH v3 0/3] compat/mingw: implement POSIX-style atomic renames
Date: Tue, 05 Nov 2024 19:54:40 -0800	[thread overview]
Message-ID: <xmqqwmhhow3j.fsf@gitster.g> (raw)
In-Reply-To: <cover.1730042775.git.ps@pks.im> (Patrick Steinhardt's message of "Sun, 27 Oct 2024 16:39:32 +0100")

Patrick Steinhardt <ps@pks.im> writes:

> Hi,
>
> this is third version of my patch series that introduces POSIX-style
> atomic renames on Windows to fix concurrent writes with the reftable
> backend.
>
> Changes compared to v2:
>
>   - Use `DWORD` instead of `int` to store the `access` flags.
>
>   - Fix handling of `oflags`.
>
>   - Add a comment referring to `mingw_open_append()` for why convert
>     `ERROR_INVALID_PARAMETER` to `ERROR_PATH_NOT_FOUND`.
>
> Thanks!
>
> Patrick

Thanks, Patrick, for listing those who gave reviews on the previous
iterations of these patches.

Reviewers, how does this round look to you?  Is this a version you
folks are comfortable to have in 'next' and later in 'master'?

Thanks.

  parent reply	other threads:[~2024-11-06  3:54 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-23 15:04 [PATCH 0/3] compat/mingw: implement POSIX-style atomic renames Patrick Steinhardt
2024-10-23 15:04 ` [PATCH 1/3] compat/mingw: share file handles created via `CreateFileW()` Patrick Steinhardt
2024-10-23 16:18   ` Kristoffer Haugsbakk
2024-10-23 17:25     ` Taylor Blau
2024-10-23 17:23   ` Taylor Blau
2024-10-23 17:25     ` Taylor Blau
2024-10-24  6:30     ` Patrick Steinhardt
2024-10-27 13:14     ` Johannes Sixt
2024-10-27 23:46       ` Taylor Blau
2024-10-23 15:05 ` [PATCH 2/3] compat/mingw: allow deletion of most opened files Patrick Steinhardt
2024-10-23 16:17   ` Kristoffer Haugsbakk
2024-10-23 17:30     ` Taylor Blau
2024-10-24  6:30     ` Patrick Steinhardt
2024-10-23 18:07   ` Taylor Blau
2024-10-23 15:05 ` [PATCH 3/3] compat/mingw: support POSIX semantics for atomic renames Patrick Steinhardt
2024-10-23 16:19   ` Kristoffer Haugsbakk
2024-10-24  6:30     ` Patrick Steinhardt
2024-10-24  7:18       ` Kristoffer Haugsbakk
2024-10-24  7:20         ` Patrick Steinhardt
2024-10-23 18:30   ` Taylor Blau
2024-10-23 15:36 ` [PATCH 0/3] compat/mingw: implement POSIX-style " Taylor Blau
2024-10-24 11:46 ` [PATCH v2 " Patrick Steinhardt
2024-10-24 11:46   ` [PATCH v2 1/3] compat/mingw: share file handles created via `CreateFileW()` Patrick Steinhardt
2024-10-24 11:46   ` [PATCH v2 2/3] compat/mingw: allow deletion of most opened files Patrick Steinhardt
2024-10-27 13:17     ` Johannes Sixt
2024-10-27 15:38       ` Patrick Steinhardt
2024-10-27 23:48         ` Taylor Blau
2024-10-27 23:51           ` Taylor Blau
2024-10-24 11:46   ` [PATCH v2 3/3] compat/mingw: support POSIX semantics for atomic renames Patrick Steinhardt
2024-10-27 13:23     ` Johannes Sixt
2024-10-27 15:38       ` Patrick Steinhardt
2024-10-27 16:31         ` Johannes Sixt
2024-10-27 17:27           ` Patrick Steinhardt
2024-10-27 21:36             ` Johannes Sixt
2024-10-27 23:50               ` Taylor Blau
2024-10-24 16:47   ` [PATCH v2 0/3] compat/mingw: implement POSIX-style " Taylor Blau
2024-10-27 13:27   ` Johannes Sixt
2024-10-27 15:39 ` [PATCH v3 " Patrick Steinhardt
2024-10-27 15:39   ` [PATCH v3 1/3] compat/mingw: share file handles created via `CreateFileW()` Patrick Steinhardt
2024-10-27 15:39   ` [PATCH v3 2/3] compat/mingw: allow deletion of most opened files Patrick Steinhardt
2024-10-27 15:39   ` [PATCH v3 3/3] compat/mingw: support POSIX semantics for atomic renames Patrick Steinhardt
2024-11-06  3:54   ` Junio C Hamano [this message]
2024-11-06  6:44     ` [PATCH v3 0/3] compat/mingw: implement POSIX-style " Johannes Sixt
2024-11-06 12:09       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqwmhhow3j.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=j6t@kdbg.org \
    --cc=johannes.schindelin@gmx.de \
    --cc=kristofferhaugsbakk@fastmail.com \
    --cc=me@ttaylorr.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).