From: Junio C Hamano <gitster@pobox.com>
To: "Kyle Lippincott via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Kyle Lippincott <spectral@google.com>
Subject: Re: [PATCH] attr: fix msan issue in read_attr_from_index
Date: Mon, 17 Jun 2024 14:14:57 -0700 [thread overview]
Message-ID: <xmqqwmmn46ge.fsf@gitster.g> (raw)
In-Reply-To: <xmqqcyof5n2t.fsf@gitster.g> (Junio C. Hamano's message of "Mon, 17 Jun 2024 13:30:34 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> Having said all that ...
>
>> Make the call to `read_attr_from_buf` conditional on `buf` being
>> non-NULL, ensuring that `size` is not read if it's never set.
>
> ... this makes the logic at the caller crystal clear, so even if
> there are suboptimal checker that bothers us with false positives,
> the change itself justifies itself, I would say.
Well, "even if there were *no* MSAN or other issues wrt usage of size"
was what I wanted to say. Sorry for a noise.
>> } else {
>> buf = read_blob_data_from_index(istate, path, &size);
>> - stack = read_attr_from_buf(buf, size, path, flags);
>> + if (buf)
>> + stack = read_attr_from_buf(buf, size, path, flags);
>> }
>> return stack;
>
> Thanks.
next prev parent reply other threads:[~2024-06-17 21:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 20:00 [PATCH] attr: fix msan issue in read_attr_from_index Kyle Lippincott via GitGitGadget
2024-06-17 20:08 ` Junio C Hamano
2024-06-17 20:30 ` Junio C Hamano
2024-06-17 21:14 ` Junio C Hamano [this message]
2024-06-17 21:17 ` Kyle Lippincott
2024-06-18 23:39 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwmmn46ge.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=spectral@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).