From: Junio C Hamano <gitster@pobox.com>
To: Josh Steadmon <steadmon@google.com>
Cc: Marcel Telka <marcel@telka.sk>, git@vger.kernel.org
Subject: Re: [PATCH] scalar: make enlistment delete to work on all POSIX platforms
Date: Thu, 30 May 2024 14:17:37 -0700 [thread overview]
Message-ID: <xmqqwmnbngni.fsf@gitster.g> (raw)
In-Reply-To: <v6q5pahyzcoa7c6tp2x63awvtc6xvjjpi4kl5okgk5qi4god7f@yg55zwwmcuzt> (Josh Steadmon's message of "Thu, 30 May 2024 13:57:13 -0700")
Josh Steadmon <steadmon@google.com> writes:
> This looks like a straightforward change; none of the formerly protected
> logic uses anything specific to Windows, and tests still pass on Linux,
> so this looks good to me.
>
> Reviewed-by: Josh Steadmon <steadmon@google.com>
Thanks.
With Dscho's Ack we saw earlier, I should have marked the topic for
'next' already, but I was placing a lot of things on back burner. A
gentle nudge like this is greatly appreciated.
Will merge to 'next'. Thanks.
prev parent reply other threads:[~2024-05-30 21:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-17 14:42 [PATCH] scalar: make enlistment delete to work on all POSIX platforms Marcel Telka
2024-05-17 20:49 ` Junio C Hamano
2024-05-18 19:45 ` Johannes Schindelin
2024-05-30 20:57 ` Josh Steadmon
2024-05-30 21:17 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwmnbngni.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=marcel@telka.sk \
--cc=steadmon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).