From: Junio C Hamano <gitster@pobox.com>
To: Max Gautier <mg@max.gautier.name>
Cc: git@vger.kernel.org, Hans Jerry Illikainen <hji@dyntopia.com>
Subject: Re: [PATCH] editorconfig: add Makefiles to "text files"
Date: Sun, 24 Mar 2024 19:54:00 -0700 [thread overview]
Message-ID: <xmqqwmprm37b.fsf@gitster.g> (raw)
In-Reply-To: <Zf_cSWY9DxVxKZu2@framework> (Max Gautier's message of "Sun, 24 Mar 2024 08:54:49 +0100")
Max Gautier <mg@max.gautier.name> writes:
> But yeah, "per-directory customization" isn't good, it multiplies the
> place to look when the config is not correct. I was mentioning by fear
> that using only one file would be hard to manage is there is too much
> patterns.
Understood.
My primary point is that we are not using too many patterns
currently, and hence many files are *not* covered by .editorconfig
rules. Some files may not even be meant to be edited by an editor,
but many others are allowed to be edited without enforcing any style
with .editorconfig and how to format them is up to the developers.
Applying a default rule to these files to enforce consistency may be
better than uncontrolled random mess each developer may leave
without any rules, and at the same time, doing so would mean we do
not have keep adding to the "C uses this rule, Shell uses this rule,
oh, now we also want Makefile to use this use" enumeration.
There may be fallouts (i.e., "For files of type X that currently are
not governed by .editorconfig, the indent-with-tab rule is not
suitable, but suddenly these files are subject to the default rule")
but adjusting the rules with exception would be more explicit and
clarify the rules.
prev parent reply other threads:[~2024-03-25 2:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 22:17 [PATCH] editorconfig: add Makefiles to "text files" Max Gautier
2024-03-22 22:40 ` Junio C Hamano
2024-03-23 15:55 ` Max Gautier
2024-03-23 17:36 ` Junio C Hamano
2024-03-24 7:54 ` Max Gautier
2024-03-25 2:54 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwmprm37b.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=hji@dyntopia.com \
--cc=mg@max.gautier.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).