From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] test-lib: set UBSAN_OPTIONS to match ASan
Date: Thu, 21 Sep 2023 14:18:49 -0700 [thread overview]
Message-ID: <xmqqwmwj443q.fsf@gitster.g> (raw)
In-Reply-To: <20230921041825.GA2814583@coredump.intra.peff.net> (Jeff King's message of "Thu, 21 Sep 2023 00:18:25 -0400")
Jeff King <peff@peff.net> writes:
> So that's garbage memory which would _usually_ cause us to segfault, but
> UBSan catches it and complains first about the alignment. That makes
> sense, but the weird thing is that UBSan then exits instead of aborting,
> so our test_might_fail call considers that an acceptable outcome and the
> test "passes".
t4058 unexpectedly succeeding vaguely rings a bell to me, too, but
it has been sporadic. The changes are obviously the right thing to
do.
Thanks, queued.
prev parent reply other threads:[~2023-09-21 21:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 4:18 [PATCH] test-lib: set UBSAN_OPTIONS to match ASan Jeff King
2023-09-21 21:18 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwmwj443q.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).