git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Andreas Herrmann <aherrmann@suse.de>, git@vger.kernel.org
Subject: Re: [PATCH] t4002: fix test #63 (missing whitespace)
Date: Tue, 25 Jul 2023 09:49:01 -0700	[thread overview]
Message-ID: <xmqqwmyolywy.fsf@gitster.g> (raw)
In-Reply-To: <CAPig+cS8=iJD4fwvSacvWTK0WUH_DyjkQuMVP00aV+e4Q4TL3g@mail.gmail.com> (Eric Sunshine's message of "Tue, 25 Jul 2023 03:10:15 -0400")

Eric Sunshine <sunshine@sunshineco.com> writes:

> Thanks for finding this problem and submitting a fix. You're the
> second person to do so[1].
>
> [1]: https://lore.kernel.org/git/pull.1545.git.git.1689341410476.gitgitgadget@gmail.com/
>
>> diff --git a/t/t4002-diff-basic.sh b/t/t4002-diff-basic.sh
>> @@ -401,9 +401,10 @@ test_expect_success 'diff-tree B A == diff-tree -R A B' '
>>  test_expect_success 'diff-tree -r B A == diff-tree -r -R A B' '
>>         git diff-tree -r $tree_B $tree_A >.test-a &&
>>         git diff-tree -r -R $tree_A $tree_B >.test-b &&
>> -       cmp -s .test-a .test-b'
>> +       cmp -s .test-a .test-b
>> +'
>
> This minor style fixup could be resubmitted as a standalone patch,
> though it might be too minor to worry about.

Thanks for a quick review and encouraging words.  I do not mind a
patch with only the above hunk but of course the title and the log
message would have to be updated ;-).

      reply	other threads:[~2023-07-25 16:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-25  6:34 [PATCH] t4002: fix test #63 (missing whitespace) Andreas Herrmann
2023-07-25  7:10 ` Eric Sunshine
2023-07-25 16:49   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqwmyolywy.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=aherrmann@suse.de \
    --cc=git@vger.kernel.org \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).