From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
git@vger.kernel.org, "David Greaves" <david@dgreaves.com>,
"Petr Baudis" <pasky@ucw.cz>
Subject: Re: [PATCH] fsck doc: remove ancient out-of-date diagnostics
Date: Wed, 20 Jan 2021 19:11:12 -0800 [thread overview]
Message-ID: <xmqqwnw7c7cf.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <YAbtH5hSiRTwulGv@nand.local> (Taylor Blau's message of "Tue, 19 Jan 2021 09:30:55 -0500")
Taylor Blau <me@ttaylorr.com> writes:
> On Sat, Jan 16, 2021 at 06:15:00PM +0100, Ævar Arnfjörð Bjarmason wrote:
>> Remove diagnostics that haven't been emitted by "fsck" or its
>> predecessors for around 15 years. This documentation was added in
>> c64b9b88605 (Reference documentation for the core git commands.,
>> 2005-05-05), but was out-of-date quickly after that.
>>
>> Notes on individual diagnostics:
>>
>> - "expect dangling commits": Added in bcee6fd8e71 (Make 'fsck' able
>> to[...], 2005-04-13), documented in c64b9b88605. Not emitted since
>> 1024932f019 (fsck-cache: walk the 'refs' directory[...],
>> 2005-05-18).
>>
>> - "missing sha1 directory": Added in 20222118ae4 (Add first cut at
>> "fsck-cache"[...], 2005-04-08), documented in c64b9b88605. Not
>> emitted since 230f13225df (Create object subdirectories on demand,
>> 2005-10-08).
>
> Thanks for digging on both of these. I checked independently and came to
> the same conclusion that you did, so I agree that these can be safely
> removed.
>
> Reviewed-by: Taylor Blau <me@ttaylorr.com>
>
> Thanks,
> Taylor
Thanks, both.
prev parent reply other threads:[~2021-01-21 3:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-22 19:50 [PATCH] More docs David Greaves
2005-04-22 20:45 ` Junio C Hamano
2005-04-22 21:44 ` David Greaves
2005-04-22 22:23 ` Junio C Hamano
2021-01-16 17:15 ` [PATCH] fsck doc: remove ancient out-of-date diagnostics Ævar Arnfjörð Bjarmason
2021-01-19 14:30 ` Taylor Blau
2021-01-21 3:11 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwnw7c7cf.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=david@dgreaves.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=pasky@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).