From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "SZEDER Gábor" <szeder.dev@gmail.com>,
"Taylor Blau" <me@ttaylorr.com>,
git@vger.kernel.org
Subject: Re: racy test failure in tb/upload-pack-filters
Date: Wed, 05 Aug 2020 09:28:42 -0700 [thread overview]
Message-ID: <xmqqwo2dnjk5.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200805092658.GA1803042@coredump.intra.peff.net> (Jeff King's message of "Wed, 5 Aug 2020 05:26:58 -0400")
Jeff King <peff@peff.net> writes:
> By the way, grepping for "remote error:" shows that when we get an error
> over sideband 3 we produce the same message but _don't_ translate it.
> That seems inconsistent.
IOW
die(_("remote error: %s"), buf + 1);
in sideband.c? I think it makes sense.
IIRC, the current thinking is to let the remote side localize their
message before sending them over the wire and we'll worry about how
we let the receiving end tell what l10n it wants later. So "remote
error:" prefix may have to be translated on receiving end and the
remainder of the line, which is already localized, can just be
interpolated.
next prev parent reply other threads:[~2020-08-05 20:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-05 8:42 racy test failure in tb/upload-pack-filters Jeff King
2020-08-05 9:06 ` SZEDER Gábor
2020-08-05 9:26 ` Jeff King
2020-08-05 15:10 ` Taylor Blau
2020-08-05 16:28 ` Junio C Hamano [this message]
2020-08-07 8:56 ` [PATCH] sideband: mark "remote error:" prefix for translation Jeff King
2020-08-07 20:18 ` Junio C Hamano
2020-08-05 9:27 ` racy test failure in tb/upload-pack-filters Martin Ågren
2020-08-05 10:03 ` Jeff King
2020-08-05 11:35 ` Martin Ågren
2020-08-05 15:08 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwo2dnjk5.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).