git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Paolo Bonzini <bonzini@gnu.org>,
	git@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] tests: do not use "slave branch" nomenclature
Date: Thu, 18 Jun 2020 11:08:01 -0700	[thread overview]
Message-ID: <xmqqwo44nt6m.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200618164554.GA616157@coredump.intra.peff.net> (Jeff King's message of "Thu, 18 Jun 2020 12:45:54 -0400")

Jeff King <peff@peff.net> writes:

> On Thu, Jun 18, 2020 at 06:38:43PM +0200, Paolo Bonzini wrote:
>
>> From: Paolo Bonzini <pbonzini@redhat.com>
>> 
>> Git does not have slave branches and has never had.  Independent
>> of any future change to the naming of branches, remove the sole
>> appearance of the term.
>
> I think this is a sensible change, though note that something simpler
> was proposed recently:
>
>   https://lore.kernel.org/git/20200610165441.iktvzuwz44sbytfg@chatter.i7.local/
>
> and the review suggested using a name that is even more meaningful to
> the test case (so we not just remove the unwanted names, but make the
> test easier to follow).

Thanks for spotting that both versions share the same issue.  We'd
just need a single one that is fixed up ;-).

  reply	other threads:[~2020-06-18 18:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-18 16:38 [PATCH] tests: do not use "slave branch" nomenclature Paolo Bonzini
2020-06-18 16:45 ` Jeff King
2020-06-18 18:08   ` Junio C Hamano [this message]
2020-06-19  9:20     ` Michal Suchánek
2020-06-19  9:23       ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqwo44nt6m.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=bonzini@gnu.org \
    --cc=git@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).