From: Junio C Hamano <gitster@pobox.com>
To: Gal Paikin <paiking@google.com>
Cc: git@vger.kernel.org
Subject: Re: Updating the commit message for reverts
Date: Mon, 30 Dec 2019 08:52:17 -0800 [thread overview]
Message-ID: <xmqqwoadhi2m.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CAEsQYpMJGbw3L66vCd25Ht0bTBzvvt1yMRd2U3=u3U-BZukyzg@mail.gmail.com> (Gal Paikin's message of "Fri, 27 Dec 2019 11:13:47 +0100")
Gal Paikin <paiking@google.com> writes:
> So the idea of changing from "Revert Revert" to "Reland", "reapply"
> has a big problem: sometimes Revert^2 actually means 'reverting
> "Revert"' since "Revert" introduced a bug that wasn't in the original
> change.
Sorry, I do not see a relevance of the above in this discussion, as
the situation does not improve if you phrase it as "Revert^2" or
"Second Revert".
Also as somebody else said in downthread, the phrasing "second
revert" would typically mean "a patch gets applied, proves to be
premature and gets reverted, the revert is reverted because the
situation in the rest of the system improved to make the orignal
patch viable, and then gets reverted again due to some other
issues", i.e. "Revert Revert Revert do something", so it is even
worse.
next prev parent reply other threads:[~2019-12-30 16:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-24 11:06 Updating the commit message for reverts Gal Paikin
2019-12-24 19:15 ` Junio C Hamano
2019-12-27 10:13 ` Gal Paikin
2019-12-28 13:20 ` Danh Doan
2019-12-30 16:52 ` Junio C Hamano [this message]
2019-12-30 19:55 ` Jonathan Nieder
2019-12-30 19:59 ` Jonathan Nieder
2019-12-30 20:33 ` Oswald Buddenhagen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwoadhi2m.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=paiking@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).