From: Junio C Hamano <gitster@pobox.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: Philippe Blain <levraiphilippeblain@gmail.com>,
Philippe Blain via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Thomas Rast <tr@thomasrast.ch>
Subject: Re: [PATCH 2/2] Documentation/git-log: mention that line-log regex must match in starting revision
Date: Wed, 18 Dec 2019 09:59:51 -0800 [thread overview]
Message-ID: <xmqqwoatecq0.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <d8e753ec-2835-331f-99de-35a4a5369b48@gmail.com> (Derrick Stolee's message of "Wed, 18 Dec 2019 05:55:25 -0500")
Derrick Stolee <stolee@gmail.com> writes:
> On 12/17/2019 10:28 PM, Philippe Blain wrote:
>>
>>> Le 17 déc. 2019 à 13:16, Junio C Hamano <gitster@pobox.com> a écrit :
>>> Even when you specify <start> or <end> as a line number, they must
>>> exist in the starting revision or it would be a fatal error. If we
>>> are clarifying with this patch for completeness, I think we should
>>> also mention it together.
> ...
>> git log -L 300,2000000085:Documentation/git-log.txt
>> errors out:
>> fatal: file Documentation/git-log.txt has only 239 lines
>
> This case seems important enough to include what it means to "match".
Yup, that is why I suggested not to focus too much on regexp and
"match"-ing, but express it in terms of the lines that are specified
by given arguments to "exist". The word "match" gives an incorrect
connotation that the description in the paragraph that uses the verb
applies only to regexp.
next prev parent reply other threads:[~2019-12-18 17:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 5:07 [PATCH 0/2] Improve line log documentation Philippe Blain via GitGitGadget
2019-12-17 5:07 ` [PATCH 1/2] Documentation/git-log: document accepted line-log diff formats Philippe Blain via GitGitGadget
2019-12-17 11:33 ` SZEDER Gábor
2019-12-18 2:44 ` Philippe Blain
2019-12-17 15:33 ` Derrick Stolee
2019-12-18 2:47 ` Philippe Blain
2019-12-17 5:07 ` [PATCH 2/2] Documentation/git-log: mention that line-log regex must match in starting revision Philippe Blain via GitGitGadget
2019-12-17 15:34 ` Derrick Stolee
2019-12-17 18:16 ` Junio C Hamano
2019-12-18 3:28 ` Philippe Blain
2019-12-18 10:55 ` Derrick Stolee
2019-12-18 11:49 ` SZEDER Gábor
2019-12-18 17:59 ` Junio C Hamano [this message]
2019-12-26 17:46 ` Philippe Blain
2019-12-18 11:09 ` SZEDER Gábor
2019-12-26 17:43 ` [PATCH v2 0/2] Improve line log documentation Philippe Blain via GitGitGadget
2019-12-26 17:43 ` [PATCH v2 1/2] doc: log, gitk: document accepted line-log diff formats Philippe Blain via GitGitGadget
2019-12-26 17:43 ` [PATCH v2 2/2] doc: log, gitk: line-log arguments must exist in starting revision Philippe Blain via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwoatecq0.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=levraiphilippeblain@gmail.com \
--cc=stolee@gmail.com \
--cc=tr@thomasrast.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).